Review TYPO3_6-1 Abandoned

32967[BUGFIX] FE cookie lifetime was ignored

Markus Hölzle CR 0 V 0 Easy +1 −1 updated 11/16/14, 15:43

Commit message

FE cookie lifetime was ignore when anonymous user.
The FrontendUserAuthentication should check in
isRefreshTimeBaseCookie() function whether the
cookie lifetime is set (Install Tool) and
check the users 'ses_permanent' only if a user
is logged in.
Without this the 'stay logged in' function of
TYPO3 didn't work in all browsers.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 6

  1. Markus Hölzle uploaded patch set 1 09/25/14, 08:34

  2. Markus Klein commented on patch set 1 CR -2 09/25/14, 09:26

    Hi Markus! Thanks for your patch. Unfortunately you pushed this patch for 6.1, but we fix bugs on the master branch first and do the backports afterwards, unless this bug is only present in 6.1. I'm block this review meanwhile, until a patch for master is merged. Please comment here if you think this bug is only present in 6.1. Thanks.
  3. Markus Hölzle commented on patch set 1 09/25/14, 09:59

    Hi Markus! I can't reproduce the bug with TYPO3 6.2 so I think it's just for 6.1
  4. Markus Klein commented on patch set 1 CR +1 09/25/14, 22:27

    Alright then
  5. Helmut Hummel commented on patch set 1 CR -2 11/05/14, 14:07

    thanks for the patch! I really appreciate the time spent on this. However I fear we cannot just change the behavior for a released branch. Please see further explanations in the forge ticket.
  6. Christian Kuhn abandoned the change 11/16/14, 15:43

    The issue was closed on forge already, this patch is abandoned.