Review main Merged

32979[TASK] CSS: Remove horizontal gray lines "uppercase"

Felix Kopp CR +2 V +2 Easy +4 −17 updated 10/03/14, 11:21

Commit message

Class "uppercase" had been used to create visual hierarchy in backend
modules. Now we have H1-H6.

Review

  • Code review CR +2
    • Georg Ringer +2
  • Verified V +2
    • Georg Ringer +2

Issues 1

Files 3

Review log 7

  1. Felix Kopp uploaded patch set 1 09/25/14, 21:46

  2. Felix Kopp commented on patch set 1 09/25/14, 21:47

    The property parameter for DocumentTemplate section can no be deprecated itself. Would you like to remove the CSS class from HTML output also?
  3. Markus Klein updated the commit message in patch set 2 09/25/14, 22:51

  4. Markus Klein commented on patch set 2 09/25/14, 22:52

    Removing a CSS class is fine IMO
  5. Georg Ringer commented on patch set 2 V +1 CR +1 09/28/14, 19:52

    yeah it would make sense to remove the class itself aswell!
  6. Georg Ringer voted on patch set 2 V +2 CR +2 10/03/14, 11:21

  7. Georg Ringer merged patch set 2 10/03/14, 11:21