Review main Merged

32991[TASK] Improve comment of GeneralUtility::makeInstance()

mostwanted CR +2 V +2 Easy +6 −0 updated 10/02/14, 10:09

Commit message

A note about the fact, that ObjectManager::get() is injecting
dependencies may be helpful.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Alexander Opitz +1
  • Verified V +2
    • Georg Ringer +2
    • Alexander Opitz +1

Issues 1

Files 1

Review log 7

  1. mostwanted uploaded patch set 1 09/27/14, 09:10

  2. mostwanted uploaded patch set 2 09/27/14, 09:12

  3. mostwanted uploaded patch set 3 09/27/14, 09:14

  4. Georg Ringer updated the commit message in patch set 4 10/02/14, 04:32

  5. Georg Ringer voted on patch set 4 V +2 CR +2 10/02/14, 04:32

  6. Alexander Opitz voted on patch set 4 V +1 CR +1 10/02/14, 07:29

  7. Markus Klein merged patch set 4 10/02/14, 10:09