Review main Merged

32996[BUGFIX] DBAL admin_query() check array before accessing it

Markus Klein CR +2 V +2 Easy +1 −1 updated 09/28/14, 20:45

Commit message

Move the $parsedQuery array access after the is_array() check in
DatabaseConnection::admin_query() to avoid PHP warnings.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Christian Kuhn +1
  • Verified V +2
    • Wouter Wolters +2
    • Christian Kuhn +1

Issues 1

Files 1

Review log 5

  1. Markus Klein uploaded patch set 1 09/28/14, 13:59

  2. Christian Kuhn voted on patch set 1 CR +1 V +1 09/28/14, 14:05

  3. Wouter Wolters voted on patch set 1 V +2 CR +2 09/28/14, 20:45

  4. Wouter Wolters merged patch set 1 09/28/14, 20:45

  5. Wouter Wolters commented on patch set 2 09/28/14, 20:45

    Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit 19c7de996af8df4e95079242524b7181ab2188e2