33048[!!!][TASK] Move flash message output to alerts
Commit message
Review
-
Code review CR +2
- Felix Kopp +2
- Georg Ringer +1
-
Verified V +2
- Felix Kopp +2
- Georg Ringer +1
Issues 1
Files 8
- typo3/sysext/core/Classes/Messaging/FlashMessage.php+6 −6
- typo3/sysext/core/Documentation/Changelog/master/Breaking-61959-FlashMessageClasses.rstnew+30 −0
- typo3/sysext/lowlevel/Classes/View/DatabaseIntegrityView.php1+1 −1
- typo3/sysext/reports/Classes/Report/Status/Status.php+4 −4
- typo3/sysext/sv/Classes/Report/ServicesListReport.php+4 −4
- typo3/sysext/t3skin/Resources/Private/Styles/TYPO3/_deprecated.less2+98 −1
- typo3/sysext/t3skin/Resources/Private/Styles/TYPO3/_element_message.less+5 −95
- typo3/sysext/t3skin/Resources/Public/Css/visual/t3kin.css+119 −114
Review log 16
-
Georg Ringer uploaded patch set 1 09/29/14, 20:15
-
Felix Kopp commented on patch set 1 09/29/14, 22:32
Nice! We might have to add !!! since people might have used the CSS classes directly -
Andreas Kienast commented on patch set 1 09/30/14, 06:28
DatabaseIntegrityView.php:324alert-body, since this class is changed in FlashMessage.php -
Georg Ringer uploaded patch set 2 10/19/14, 18:09
-
Benni Mack commented on patch set 2 CR +1 10/20/14, 19:49
I think this is breaking (thinking of all my BE Modules and FE plugins using flash messages). Could you add a !!! and a ReST note? -
Felix Kopp commented on patch set 2 10/20/14, 21:31
Yes, this is a breaking patch. I fear modules might have used the FlashMessage html output without the class. But having used in-official API can be changed. Let us add !!! but mere this patch in order to ease element_messages -
Felix Kopp commented on patch set 2 10/20/14, 21:33
_deprecated.less:111I would remove the former CSS definitions since we had an API. No deprecation required here -
Georg Ringer commented on patch set 2 10/21/14, 03:12
what about adding a VH as well for the alerts?_deprecated.less:111Replyexcept for all backend modules where devs like me used the html directly ... -
Stefan Froemken commented on patch set 2 10/21/14, 07:55
Works good, but I miss a little CSS for alert-header. For now it has the same style than the text below. Can we make is "strong"? -
Stefan Froemken voted on patch set 2 V -1 10/21/14, 07:55
-
Stefan Froemken voted on patch set 2 V +1 10/21/14, 07:55
-
Georg Ringer uploaded patch set 3 10/21/14, 15:05
-
Felix Kopp uploaded patch set 4 10/25/14, 22:01
-
Felix Kopp commented on patch set 4 CR +2 V +2 10/25/14, 22:02
Changed "header" to h4 as Bootstrap requests. Also re-generated t3skin.css -
Georg Ringer voted on patch set 4 V +1 CR +1 10/25/14, 22:08
-
Felix Kopp merged patch set 4 10/25/14, 22:13