Review main Merged Breaking

33048[!!!][TASK] Move flash message output to alerts

Georg Ringer CR +2 V +2 Hard +267 −225 updated 10/25/14, 22:13

Commit message

Since bootstrap is available it would make sense to
use the alert classes instead of the custom implementation.

Review

  • Code review CR +2
    • Felix Kopp +2
    • Georg Ringer +1
  • Verified V +2
    • Felix Kopp +2
    • Georg Ringer +1

Issues 1

Files 8

Review log 16

  1. Georg Ringer uploaded patch set 1 09/29/14, 20:15

  2. Felix Kopp commented on patch set 1 09/29/14, 22:32

    Nice! We might have to add !!! since people might have used the CSS classes directly
  3. Andreas Kienast commented on patch set 1 09/30/14, 06:28

    DatabaseIntegrityView.php:324

    alert-body, since this class is changed in FlashMessage.php
  4. Georg Ringer uploaded patch set 2 10/19/14, 18:09

  5. Benni Mack commented on patch set 2 CR +1 10/20/14, 19:49

    I think this is breaking (thinking of all my BE Modules and FE plugins using flash messages). Could you add a !!! and a ReST note?
  6. Felix Kopp commented on patch set 2 10/20/14, 21:31

    Yes, this is a breaking patch. I fear modules might have used the FlashMessage html output without the class. But having used in-official API can be changed. Let us add !!! but mere this patch in order to ease element_messages
  7. Felix Kopp commented on patch set 2 10/20/14, 21:33

    _deprecated.less:111

    I would remove the former CSS definitions since we had an API. No deprecation required here
  8. Georg Ringer commented on patch set 2 10/21/14, 03:12

    what about adding a VH as well for the alerts?

    _deprecated.less:111 Reply

    except for all backend modules where devs like me used the html directly ...
  9. Stefan Froemken commented on patch set 2 10/21/14, 07:55

    Works good, but I miss a little CSS for alert-header. For now it has the same style than the text below. Can we make is "strong"?
  10. Stefan Froemken voted on patch set 2 V -1 10/21/14, 07:55

  11. Stefan Froemken voted on patch set 2 V +1 10/21/14, 07:55

  12. Georg Ringer uploaded patch set 3 10/21/14, 15:05

  13. Felix Kopp uploaded patch set 4 10/25/14, 22:01

  14. Felix Kopp commented on patch set 4 CR +2 V +2 10/25/14, 22:02

    Changed "header" to h4 as Bootstrap requests. Also re-generated t3skin.css
  15. Georg Ringer voted on patch set 4 V +1 CR +1 10/25/14, 22:08

  16. Felix Kopp merged patch set 4 10/25/14, 22:13