Review main Merged

33101[BUGFIX] Properly handle non-existing language key

Markus Klein CR +2 V +2 Easy +15 −23 updated 11/19/14, 19:55

Commit message

Review

  • Code review CR +2
    • Frank Nägler +2
    • Stefan Neufeind +1
    • Mathias Schreiber +1
    • Krzysztof Adamczyk +1
    • Stefan Froemken +1
    • Andreas Kienast +1
  • Verified V +2
    • Frank Nägler +2
    • Mathias Schreiber +1

Issues 1

Files 1

Review log 9

  1. Markus Klein uploaded patch set 1 10/02/14, 09:58

  2. Stefan Froemken commented on patch set 1 CR +1 10/03/14, 00:54

    LanguageService.php:238

    I love the old description. It shows the differences between these methods very clearly.
  3. Markus Klein commented on patch set 1 10/03/14, 08:27

    LanguageService.php:238 Reply

    But the old one is wrong now. It does not behave like getLL anymore, but getLL is like getLLL now.
  4. Andreas Kienast voted on patch set 1 CR +1 10/24/14, 08:00

  5. Krzysztof Adamczyk voted on patch set 1 CR +1 11/10/14, 19:09

  6. Mathias Schreiber commented on patch set 1 CR +1 V +1 11/19/14, 08:25

    This one is so obvious it hurts :)
  7. Stefan Neufeind commented on patch set 1 CR +1 11/19/14, 08:43

    Looks quite obvious and fine to me. General unit-tests run fine.

    LanguageService.php:238 Reply

    I'm with Markus here.
  8. Frank Nägler voted on patch set 1 V +2 CR +2 11/19/14, 19:55

  9. Frank Nägler merged patch set 1 11/19/14, 19:55