Review main Merged

33122[TASK] Improve namings of CheckboxElement

Wouter Wolters CR +2 V +2 Normal +56 −32 updated 10/03/14, 19:50

Commit message

Use better namings for variables in CheckboxElement.

Count of selectedItems is done multiple times.
Better is to do the counting once and use the result in the
other places.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Georg Ringer +1
  • Verified V +2
    • Anja Leichsenring +2
    • Georg Ringer +1

Issues 1

Files 1

Review log 8

  1. Wouter Wolters uploaded patch set 1 10/02/14, 18:35

  2. Wouter Wolters uploaded patch set 2 10/02/14, 18:35

  3. Markus Klein commented on patch set 2 10/02/14, 22:57

    Please rebase
  4. Stefan Froemken uploaded patch set 3 10/03/14, 00:34

  5. Stefan Froemken commented on patch set 2 10/03/14, 00:36

    I have rebased the patch. It was my first rebase after a very long time. So happy testing if it works.
  6. Georg Ringer voted on patch set 3 V +1 CR +1 10/03/14, 06:36

  7. Anja Leichsenring voted on patch set 3 CR +2 V +2 10/03/14, 19:50

  8. Anja Leichsenring merged patch set 3 10/03/14, 19:50