Review main Merged

33162[CLEANUP] Remove unused code from old backend

Benni Mack CR +2 V +2 Easy +2 −18 updated 10/04/14, 13:34

Commit message

Prior to TYPO3 CMS 4.5 there were still some
variables which are not used anymore since then.

The menuReset() function does not exist anymore
as well as the CSS class "navFrameHL".

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Tymoteusz Motylewski +1
  • Verified V +2
    • Wouter Wolters +2
    • Tymoteusz Motylewski +1

Issues 1

Files 4

Review log 10

  1. Benni Mack uploaded patch set 1 10/04/14, 12:25

  2. Wouter Wolters commented on patch set 1 V +1 10/04/14, 13:05

    Code looks good to me, but the newly generated CSS contains more changes then needed. Looks like the generation of the CSS needs documentation so that everybody uses the same generation. What do you think?
  3. Tymoteusz Motylewski commented on patch set 1 CR +1 V +1 10/04/14, 13:08

    Agree with Wouter. However as we don't have guidelines it's ok for me.
  4. Benni Mack commented on patch set 1 10/04/14, 13:11

    We could remove the new css file as it does not do anything at all anyway (there is no HTML producing .navFrameHL) for now, until we have a clean way to generate the CSS from LESS.
  5. Tymoteusz Motylewski commented on patch set 1 10/04/14, 13:20

    you can do it, or just commit changes related to the .navFrameHL in the css file
  6. Wouter Wolters uploaded patch set 2 10/04/14, 13:28

  7. Wouter Wolters voted on patch set 2 V +1 CR +1 10/04/14, 13:28

  8. Tymoteusz Motylewski voted on patch set 2 CR +1 V +1 10/04/14, 13:34

  9. Wouter Wolters voted on patch set 2 V +2 CR +2 10/04/14, 13:34

  10. Wouter Wolters merged patch set 2 10/04/14, 13:34