Review main Merged

33168[TASK] Remove TBE_STYLES mainColors from PHP

Benni Mack CR +2 V +2 Normal +37 −68 updated 10/05/14, 20:04

Commit message

TYPO3 uses $TBE_STYLES to define certain
variables like background colors in PHP that
can be overridden with extensions.

In order to streamline the rendering of the
backend that should completely done via
LESS / CSS, the corresponding PHP parts are
removed, as they should have no effect
anyway - this is already done via CSS.

Review

  • Code review CR +2
    • Felix Kopp +2
  • Verified V +2
    • Felix Kopp +2

Issues 1

Files 7

Review log 5

  1. Benni Mack uploaded patch set 1 10/05/14, 08:20

  2. Felix Kopp commented on patch set 1 CR +2 V +2 10/05/14, 15:44

    Very nice! I would like to take this one step further by removing t3skin > _main_content.less color values .bgColor-* as well and all occurrences - might be in follow-up patch to keep the overview.

    DocumentTemplate.php:155

    Would like to remove the colors as well right now.

    QueryGenerator.php:954

    Class should also be removed since we currently render with the nth-child
  3. Wouter Wolters commented on patch set 1 10/05/14, 17:01

    StyleGenerationHook.php:34

    Remove the $GLOBALS['TBE_STYLES']['scriptIDindex']['typo3/alt_clickmenu.php']['mainColors']['bgColor5'] line here?
  4. Benni Mack merged patch set 1 10/05/14, 20:03

  5. Benni Mack commented on patch set 1 10/05/14, 20:04

    DocumentTemplate.php:155 Reply

    they are deprecated, and not in use anymore in the core, so they will be removed, but do no harm for now.

    QueryGenerator.php:954 Reply

    we should tackle those in another patch, there is quite a lot left.

    StyleGenerationHook.php:34 Reply

    could be used by other skins