33168[TASK] Remove TBE_STYLES mainColors from PHP
Commit message
Review
-
Code review CR +2
- Felix Kopp +2
-
Verified V +2
- Felix Kopp +2
Issues 1
Files 7
- typo3/sysext/backend/Classes/Controller/Wizard/RteController.php+0 −2
- typo3/sysext/backend/Classes/Form/FormEngine.php+0 −12
- typo3/sysext/backend/Classes/Template/DocumentTemplate.php2+7 −32
- typo3/sysext/core/Classes/Database/QueryGenerator.php2+1 −2
- typo3/sysext/core/Documentation/Changelog/master/Breaking-62039-RemovedTBE_StylesMainColors.rstnew+28 −0
- typo3/sysext/t3skin/Classes/Hook/StyleGenerationHook.php2+1 −0
- typo3/sysext/t3skin/ext_tables.php+0 −20
Review log 5
-
Benni Mack uploaded patch set 1 10/05/14, 08:20
-
Felix Kopp commented on patch set 1 CR +2 V +2 10/05/14, 15:44
Very nice! I would like to take this one step further by removing t3skin > _main_content.less color values .bgColor-* as well and all occurrences - might be in follow-up patch to keep the overview.DocumentTemplate.php:155Would like to remove the colors as well right now.QueryGenerator.php:954Class should also be removed since we currently render with the nth-child -
Wouter Wolters commented on patch set 1 10/05/14, 17:01
StyleGenerationHook.php:34Remove the $GLOBALS['TBE_STYLES']['scriptIDindex']['typo3/alt_clickmenu.php']['mainColors']['bgColor5'] line here? -
Benni Mack merged patch set 1 10/05/14, 20:03
-
Benni Mack commented on patch set 1 10/05/14, 20:04
DocumentTemplate.php:155Replythey are deprecated, and not in use anymore in the core, so they will be removed, but do no harm for now.QueryGenerator.php:954Replywe should tackle those in another patch, there is quite a lot left.StyleGenerationHook.php:34Replycould be used by other skins