Review main Merged

33169[TASK] Improve readability of TextElement code

Wouter Wolters CR +2 V +2 Normal +98 −60 updated 10/13/14, 23:07

Commit message

FormEngine type="text" in class TextElements gets some
code beautification to improve readability.

Review

  • Code review CR +2
    • Markus Klein +2
    • Christian Kuhn +1
  • Verified V +2
    • Markus Klein +2
    • Christian Kuhn +1

Issues 1

Files 1

Review log 7

  1. Wouter Wolters uploaded patch set 1 10/05/14, 15:39

  2. Stefan Froemken voted on patch set 1 CR +1 V +1 10/08/14, 09:38

  3. Stefan Neufeind commented on patch set 1 CR +1 10/09/14, 19:19

    Wow, thanks a lot. Really gives much more readability :-)
  4. Christian Kuhn updated the commit message in patch set 2 10/13/14, 22:39

  5. Christian Kuhn voted on patch set 2 CR +1 V +1 10/13/14, 22:45

  6. Markus Klein commented on patch set 2 CR +2 V +2 10/13/14, 23:07

    TextElement.php:171

    we should backport this bugfix to 6.2
  7. Markus Klein merged patch set 2 10/13/14, 23:07