Review main Merged

33194[FEATURE] Add attribute "multiple" to f:form.upload viewhelper.

Jost Baron CR +2 V +2 Easy +44 −2 updated 01/18/15, 13:37

Commit message

This makes it possible to upload multiple files with one upload field.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Helmut Hummel +2
  • Verified V +2
    • Anja Leichsenring +2

Issues 1

Files 3

Review log 23

  1. Jost Baron uploaded patch set 1 10/07/14, 20:33

  2. Wouter Wolters commented on patch set 1 10/07/14, 20:57

    hi Jost, thanks for the patch. I left 2 comments

    UploadViewHelper.php:73

    use tabs instead of spaces

    UploadViewHelper.php:76

    else should be on the same line as the closing bracket of the if
  3. Jost Baron uploaded patch set 2 10/07/14, 21:21

  4. Stefan Froemken commented on patch set 2 CR +1 V +1 10/08/14, 07:31

    Yes it works, but using it results in type converter exception "No typeConverter found to convert array to string". Sure, I know that I have to call setTargetTypeForSubProperty() in initializeCreateAction(). But what do you think? Should we add a hint?
  5. Stefan Neufeind commented on patch set 2 10/09/14, 19:22

    @StefanF: I also wondered if the multiple files are already handled correctly when using it.
  6. Stefan Neufeind commented on patch set 2 12/02/14, 12:02

    @StefanF: Could you maybe comment on the state of this?
  7. Mathias Schreiber wrote 12/17/14, 14:33

    Topic set to EXT: fluid
  8. Felix Kopp commented on patch set 2 01/16/15, 18:24

    Any objections, Anja?
  9. Anja Leichsenring commented on patch set 2 CR -1 01/18/15, 09:00

    this is a feature and therefor needs a documentation file. will work on it now.
  10. Anja Leichsenring uploaded patch set 3 01/18/15, 10:17

  11. Anja Leichsenring commented on patch set 3 01/18/15, 10:18

    added test and documentation. Please verify.
  12. Anja Leichsenring voted on patch set 3 CR +1 V +1 01/18/15, 10:18

  13. Helmut Hummel commented on patch set 3 01/18/15, 12:10

    AbstractTagBasedViewHelper.php:13

    I guess the changes in this file are not intentional
  14. Helmut Hummel commented on patch set 3 CR -1 01/18/15, 12:16

    Feature-47666-AttributeMulitpleForFormUploadViewhelper.rst:12

    can we use property="" here in the example?

    Feature-47666-AttributeMulitpleForFormUploadViewhelper.rst:27

    This passage and example is imho a bit misleading. Currently there is no property mapping at all for uploaded files. Maybe just: "Be aware, that you need to prepare the incoming value for the property mapping yourself, by writing your own TypeConverter." and removing everything else.
  15. Anja Leichsenring uploaded patch set 4 01/18/15, 12:25

  16. Helmut Hummel commented on patch set 4 CR -1 01/18/15, 12:29

    AbstractTagBasedViewHelper.php:70

    do we still need this line change as only change in this class?

    AbstractTagBasedViewHelper.php:126

    same here. pleas don't touch the file if there are no changes in it…
  17. Stefan Neufeind uploaded patch set 5 01/18/15, 12:35

  18. Stefan Neufeind commented on patch set 5 01/18/15, 12:35

    Removed file from changeset which only had two additional newlines.
  19. Anja Leichsenring uploaded patch set 6 01/18/15, 12:38

  20. Anja Leichsenring voted on patch set 6 CR +1 V +1 01/18/15, 12:45

  21. Helmut Hummel voted on patch set 6 CR +2 01/18/15, 12:48

  22. Anja Leichsenring voted on patch set 6 CR +2 V +2 01/18/15, 13:32

  23. Anja Leichsenring merged patch set 6 01/18/15, 13:37