Review main Merged

33220[BUGFIX] Show empty icon in checkbox'ed select field

Axel Kummer CR +2 V +2 Easy +3 −3 updated 10/10/14, 12:50

Commit message

When a select field has config option renderMode=checkbox, icons
are rendered between checkbox and the label. If no icon is defined,
TYPO3 ought to show an empty icon.
This is broken and a red question mark appears.
This patch fixes the problem so that the empty icon is rendered again.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Markus Klein +1
    • Christian Weiske +1
    • Stefan Froemken +1
  • Verified V +2
    • Wouter Wolters +2
    • Christian Weiske +1
    • Stefan Froemken +1

Issues 1

Files 1

Review log 15

  1. Axel Kummer uploaded patch set 1 10/09/14, 08:13

  2. Markus Klein commented on patch set 1 CR -1 10/09/14, 09:55

    Thanks for your patch Axel. I added some comments to the commit message. It looks like you created the patch on an outdated branch, hence it does not apply. I'll push an updated version.
    empty
    is broken. commit messages in present tense please.
    must be "master, 6.2"
  3. Markus Klein uploaded patch set 2 10/09/14, 10:04

  4. Markus Klein commented on patch set 2 CR +1 10/09/14, 10:05

    Please test, if this works for you.
  5. Stefan Froemken uploaded patch set 3 10/09/14, 10:25

  6. Stefan Froemken commented on patch set 3 10/09/14, 10:30

    Sorry Markus...you're faster with applying a new patch. It was a little bit too heavy for me to rebase this patch. So...any ideas how to remove my patch, because your patch is a little bit better.
  7. Markus Klein commented on patch set 3 10/09/14, 10:36

    1.) rebase was to remove all changes in the FormEngine and add them in SelectElement 2.) you forgot to set the correct author with your new version 3.) just cherry-pick set 2 and push it again. will do so now ;-)
  8. Markus Klein uploaded patch set 4 10/09/14, 10:37

  9. Stefan Froemken voted on patch set 4 CR +1 V +1 10/09/14, 10:40

  10. Christian Weiske commented on patch set 4 10/09/14, 12:25

    The patch was actually against TYPO3-6_2, which did not get the refactoring: https://git.typo3.org/Packages/TYPO3.CMS.git/blob/TYPO3_6-2:/typo3/sysext/backend/Classes/Form/FormEngine.php#l2273
  11. Christian Weiske commented on patch set 4 10/09/14, 12:27

    Ah. We did push to the wrong ref.
  12. Markus Klein commented on patch set 4 CR +1 10/09/14, 13:47

    No, you pushed to the correct ref. Patches must always be supplied for master!
  13. Christian Weiske commented on patch set 4 CR +1 V +1 10/10/14, 12:33

    Patch works fine.
  14. Wouter Wolters voted on patch set 4 V +2 CR +2 10/10/14, 12:50

  15. Wouter Wolters merged patch set 4 10/10/14, 12:50