Review main Merged

33242[BUGFIX] Ensure argument is an array in ContentObjectRenderer

Kay Strobach CR +2 V +2 Easy +2 −4 updated 10/11/14, 12:57

Commit message

This patch ensures that at least an empty array is passed to the
array_replace_recursive function to avoid warnings during rendering.

Inspired by Markus Klein

Review

  • Code review CR +2
    • Markus Klein +2
    • Stefan Froemken +1
  • Verified V +2
    • Markus Klein +2
    • Stefan Froemken +1

Issues 1

Files 1

Review log 17

  1. Kay Strobach uploaded patch set 1 10/10/14, 06:55

  2. Kay Strobach uploaded patch set 2 10/10/14, 07:51

  3. Kay Strobach uploaded patch set 3 10/10/14, 07:52

  4. Kay Strobach uploaded patch set 4 10/10/14, 07:53

  5. Markus Klein commented on patch set 4 10/10/14, 09:58

    ContentObjectRenderer.php:730

    trailing tab

    ContentObjectRenderer.php:736

    Please change that to: if (is_array($conf)) { if (is_array($old_conf) && count($old_conf)) {} else {} } else { }
  6. Markus Klein updated the commit message in patch set 5 10/10/14, 09:59

  7. Markus Klein commented on patch set 5 CR -1 10/10/14, 09:59

    Comments of set 4 still apply
  8. Kay Strobach uploaded patch set 6 10/10/14, 13:51

  9. Markus Klein commented on patch set 6 CR -1 10/10/14, 14:02

    1.) please preserve my commit message changes from set 5 2.) please restructure the code as commented for readability and performance will push a new version
  10. Markus Klein uploaded patch set 7 10/10/14, 14:03

  11. Markus Klein voted on patch set 7 CR +1 V +1 10/10/14, 14:04

  12. Kay Strobach uploaded patch set 8 10/10/14, 14:34

  13. Markus Klein voted on patch set 8 CR +1 V +1 10/10/14, 15:28

  14. Stefan Froemken commented on patch set 8 CR +1 V +1 10/10/14, 20:43

    Works good. Both NULL-values were converted to array().
  15. Markus Klein voted on patch set 8 CR +2 V +2 10/11/14, 12:57

  16. Markus Klein merged patch set 8 10/11/14, 12:57

  17. Markus Klein commented on patch set 9 10/11/14, 12:57

    Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit 39f0d8fafd1eb2e32a0c17389c9c99f919a562dd