Review main Merged

33250[BUGFIX] Wrong usage of count on SimpleXMLElement

Stefan Froemken CR +2 V +2 Easy +5 −3 updated 10/11/14, 15:27

Commit message

SimpleXMLElement comes with its own count implementation,
so no need to call count() on that Element.
Further I have updated some type annotations.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Markus Klein +1
  • Verified V +2
    • Wouter Wolters +2
    • Markus Klein +1

Issues 1

Files 1

Review log 8

  1. Stefan Froemken uploaded patch set 1 10/10/14, 12:02

  2. Stefan Froemken commented on patch set 1 10/10/14, 12:04

    This is only a test for Stefan Neufeind, to check if reading of XML locallang files works now.
  3. Markus Klein updated the commit message in patch set 2 10/10/14, 13:30

  4. Markus Klein voted on patch set 2 CR +1 V +1 10/10/14, 13:32

  5. Stefan Froemken commented on patch set 2 10/10/14, 13:35

    The problem seems to be that the file contains locallangkey instead of locallangKey. In my opinion this patch isn't bad and cleans up the code a little bit.
  6. Wouter Wolters voted on patch set 2 V +2 CR +2 10/11/14, 15:27

  7. Wouter Wolters merged patch set 2 10/11/14, 15:27

  8. Wouter Wolters commented on patch set 3 10/11/14, 15:27

    Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit 1a65ca9cb4b90d8fb8682ec7e700e92894d393b7