Review TYPO3_6-2 Merged

33266[BUGFIX] Show empty icon in checkbox'ed select field

Wouter Wolters CR +2 V +2 Easy +3 −3 updated 10/11/14, 18:45

Commit message

When a select field has config option renderMode=checkbox, icons
are rendered between checkbox and the label. If no icon is defined,
TYPO3 ought to show an empty icon.
This is broken and a red question mark appears.
This patch fixes the problem so that the empty icon is rendered again.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Stefan Froemken +1
  • Verified V +2
    • Wouter Wolters +2
    • Stefan Froemken +1

Issues 1

Files 1

Review log 4

  1. Wouter Wolters uploaded patch set 1 10/11/14, 15:31

  2. Stefan Froemken voted on patch set 1 CR +1 V +1 10/11/14, 18:44

  3. Wouter Wolters voted on patch set 1 V +2 CR +2 10/11/14, 18:45

  4. Wouter Wolters merged patch set 1 10/11/14, 18:45