Review main Merged

33277[TASK] Improve options for "Simulate backend user"

Georg Ringer CR +2 V +2 Easy +2 −1 updated 10/12/14, 19:24

Commit message

The option uses the syntax "username (real name)",
however the () are even added if no full name is available.

As a solution, add the () only if a real name is given.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Frans Saris +1
  • Verified V +2
    • Wouter Wolters +2
    • Frans Saris +1

Issues 1

Files 1

Review log 6

  1. Georg Ringer uploaded patch set 1 10/12/14, 17:36

  2. Felix Kopp updated the commit message in patch set 2 10/12/14, 18:44

  3. Frans Saris voted on patch set 2 CR +1 10/12/14, 18:47

  4. Frans Saris voted on patch set 2 V +1 10/12/14, 18:54

  5. Wouter Wolters voted on patch set 2 V +2 CR +2 10/12/14, 19:24

  6. Wouter Wolters merged patch set 2 10/12/14, 19:24