33294[BUGFIX] Display Info of File in popup instead of File Metadata
Commit message
Review
-
Code review CR +2
- Frans Saris +2
- Markus Klein +1
- Fabien Udriot +1
-
Verified V +2
- Frans Saris +2
- Markus Klein +1
- Fabien Udriot +1
Issues 1
Files 2
Review log 25
-
Fabien Udriot uploaded patch set 1 10/13/14, 15:29
-
Markus Klein commented on patch set 1 10/13/14, 15:35
FileList.php:632Is the user really interested into the timestamp when the sys_file record is modified? I guess the end user wants to know about the actual file modification date. -
Fabien Udriot commented on patch set 1 10/13/14, 15:45
ElementInformationController.php:301ReplyYes, it is. The info is not needed anymore since displaying info of a sys_file record. Those fields are related to sys_file_metadata only (and are not present in sys_file)FileList.php:632ReplySomething to discuss... It may also sound natural to display the date when the file record has been modified (e.g a new upload was made) which is the natural behaviour in CMS. In any case it should be the same info as in the popup. My customer is confusing / complaining about that. So if we revert to ModificationDate we must change that in the Info popup as well from the File List. -
Fabien Udriot updated the commit message in patch set 2 10/13/14, 15:46
-
Markus Klein commented on patch set 2 10/13/14, 15:53
Well, this is what I as an editor expect to see from a file: - What's the name - Size of the image - Resolution of the image - Modification time of the file - Who uploaded it - When was the file uploaded This information is spread over: the file itself, the sys_file and the sys_file_metadata record. Since the latter is a 1:1 relation we need to fetch data from both. -
Felix Kopp commented on patch set 2 11/02/14, 23:17
Yes, info from both imo -
Frans Saris commented on patch set 1 11/10/14, 20:10
ElementInformationController.php:174$fileOrFolderObject->getUid()ElementInformationController.php:301ReplySo we do not know (anymore), who uploaded a file? -
Felix Kopp commented on patch set 2 11/10/14, 23:49
I would like to see data from both: file and meta data -
Frans Saris uploaded patch set 3 11/20/14, 22:03
-
Benni Mack commented on patch set 3 12/11/14, 16:31
Fabien, is this ready? Probably for master only, right? -
Markus Klein commented on patch set 3 CR +1 12/11/14, 17:36
Looks good. Should go into 6.2 as well! -
Markus Klein commented on patch set 3 12/11/14, 17:57
@Frans: So this only shows the information from sys_file now, but we need some sys_file_metadata information as well. -
Frans Saris commented on patch set 3 12/11/14, 19:00
What info should be shown? And metadata is also language, version and workspace dependent.... -
Markus Klein commented on patch set 3 12/11/14, 19:45
I thought about the title for instance, but you're right that this does not make sense if it is translatable -
Markus Klein voted on patch set 3 V +1 12/11/14, 19:58
-
Benni Mack commented on patch set 3 12/30/14, 17:27
FileList.php:297any reason for this change? If so, we should probably modify this in different places and/or change the function getModificationTime() -
Frans Saris commented on patch set 3 01/11/15, 19:50
FileList.php:297ReplyNo should be getModificationTime() -
Frans Saris uploaded patch set 4 01/11/15, 19:56
-
Markus Klein voted on patch set 4 CR +1 V +1 01/11/15, 23:26
-
Benni Mack wrote 01/29/15, 17:18
Topic set to FAL -
Frans Saris voted on patch set 4 CR +1 V +1 01/30/15, 22:04
-
Fabien Udriot voted on patch set 4 CR +1 V +1 01/30/15, 23:06
-
Frans Saris voted on patch set 4 CR +2 V +2 01/30/15, 23:08
-
Frans Saris merged patch set 4 01/30/15, 23:08
-
Frans Saris commented on patch set 5 01/30/15, 23:09
Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit 90c02fb6dff4e1ffc23c6dc3a5ae12c1d6de97e5
ElementInformationController.php:301