Review main Merged

33294[BUGFIX] Display Info of File in popup instead of File Metadata

Fabien Udriot CR +2 V +2 Normal +35 −25 updated 01/30/15, 23:09

Commit message

To stay inline with the File List, the popup from the list
should display info of a File and not of the File Metadata. Otherwise,
it will display misleading information for the End User such
as different creation / modification date.

Review

  • Code review CR +2
    • Frans Saris +2
    • Markus Klein +1
    • Fabien Udriot +1
  • Verified V +2
    • Frans Saris +2
    • Markus Klein +1
    • Fabien Udriot +1

Issues 1

Files 2

Review log 25

  1. Fabien Udriot uploaded patch set 1 10/13/14, 15:29

  2. Markus Klein commented on patch set 1 10/13/14, 15:35

    ElementInformationController.php:301

    is that related to this change??

    FileList.php:632

    Is the user really interested into the timestamp when the sys_file record is modified? I guess the end user wants to know about the actual file modification date.
  3. Fabien Udriot commented on patch set 1 10/13/14, 15:45

    ElementInformationController.php:301 Reply

    Yes, it is. The info is not needed anymore since displaying info of a sys_file record. Those fields are related to sys_file_metadata only (and are not present in sys_file)

    FileList.php:632 Reply

    Something to discuss... It may also sound natural to display the date when the file record has been modified (e.g a new upload was made) which is the natural behaviour in CMS. In any case it should be the same info as in the popup. My customer is confusing / complaining about that. So if we revert to ModificationDate we must change that in the Info popup as well from the File List.
  4. Fabien Udriot updated the commit message in patch set 2 10/13/14, 15:46

  5. Markus Klein commented on patch set 2 10/13/14, 15:53

    Well, this is what I as an editor expect to see from a file: - What's the name - Size of the image - Resolution of the image - Modification time of the file - Who uploaded it - When was the file uploaded This information is spread over: the file itself, the sys_file and the sys_file_metadata record. Since the latter is a 1:1 relation we need to fetch data from both.
  6. Felix Kopp commented on patch set 2 11/02/14, 23:17

    Yes, info from both imo
  7. Frans Saris commented on patch set 1 11/10/14, 20:10

    ElementInformationController.php:174

    $fileOrFolderObject->getUid()

    ElementInformationController.php:301 Reply

    So we do not know (anymore), who uploaded a file?
  8. Felix Kopp commented on patch set 2 11/10/14, 23:49

    I would like to see data from both: file and meta data
  9. Frans Saris uploaded patch set 3 11/20/14, 22:03

  10. Benni Mack commented on patch set 3 12/11/14, 16:31

    Fabien, is this ready? Probably for master only, right?
  11. Markus Klein commented on patch set 3 CR +1 12/11/14, 17:36

    Looks good. Should go into 6.2 as well!
  12. Markus Klein commented on patch set 3 12/11/14, 17:57

    @Frans: So this only shows the information from sys_file now, but we need some sys_file_metadata information as well.
  13. Frans Saris commented on patch set 3 12/11/14, 19:00

    What info should be shown? And metadata is also language, version and workspace dependent....
  14. Markus Klein commented on patch set 3 12/11/14, 19:45

    I thought about the title for instance, but you're right that this does not make sense if it is translatable
  15. Markus Klein voted on patch set 3 V +1 12/11/14, 19:58

  16. Benni Mack commented on patch set 3 12/30/14, 17:27

    FileList.php:297

    any reason for this change? If so, we should probably modify this in different places and/or change the function getModificationTime()
  17. Frans Saris commented on patch set 3 01/11/15, 19:50

    FileList.php:297 Reply

    No should be getModificationTime()
  18. Frans Saris uploaded patch set 4 01/11/15, 19:56

  19. Markus Klein voted on patch set 4 CR +1 V +1 01/11/15, 23:26

  20. Benni Mack wrote 01/29/15, 17:18

    Topic set to FAL
  21. Frans Saris voted on patch set 4 CR +1 V +1 01/30/15, 22:04

  22. Fabien Udriot voted on patch set 4 CR +1 V +1 01/30/15, 23:06

  23. Frans Saris voted on patch set 4 CR +2 V +2 01/30/15, 23:08

  24. Frans Saris merged patch set 4 01/30/15, 23:08

  25. Frans Saris commented on patch set 5 01/30/15, 23:09

    Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit 90c02fb6dff4e1ffc23c6dc3a5ae12c1d6de97e5