Review main Merged

33296[TASK] Move MysqlFulltextIndexHook to EXT:indexed_search_mysql

Georg Ringer CR +2 V +2 Easy +2 −2 updated 10/13/14, 21:30

Commit message

The hook MysqlFulltextIndexHook should be moved from indexed_search to
indexed_search_mysql because it is only used if indexed_search_mysql is activated.

Review

  • Code review CR +2
    • Markus Klein +2
    • Christian Kuhn +1
  • Verified V +2
    • Markus Klein +2
    • Christian Kuhn +1

Issues 1

Files 2

Review log 6

  1. Georg Ringer uploaded patch set 1 10/13/14, 19:45

  2. Markus Klein commented on patch set 1 10/13/14, 19:50

    ext_localconf.php:5

    that & can go too, right?
  3. Christian Kuhn commented on patch set 1 10/13/14, 21:00

    ext_localconf.php:5 Reply

    Well aehm .. no ;) This hook class is instantiated by hookRequest() method which uses the ancient GeneralUtility::getUserObj(). This method has an own and very creative solution for singletons built in, which is triggered by a "&" at the beginning ... In short: we can not remove the & without further investigation ;)
  4. Christian Kuhn voted on patch set 1 CR +1 V +1 10/13/14, 21:01

  5. Markus Klein commented on patch set 1 CR +2 V +2 10/13/14, 21:30

    ext_localconf.php:5 Reply

    Well aehm... ok ;-) Didn't check the actual method, that's why I asked.
  6. Markus Klein merged patch set 1 10/13/14, 21:30