Review main Merged

33297[TASK] Sort BE usergroup records in module "Backend Users"

Georg Ringer CR +2 V +2 Easy +6 −0 updated 10/13/14, 20:18

Commit message

Add a default ordering for the backend usergroup records
which makes it easier to find a specific group.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Wouter Wolters +1
  • Verified V +2
    • Christian Kuhn +2

Issues 1

Files 1

Review log 9

  1. Georg Ringer uploaded patch set 1 10/13/14, 19:53

  2. Markus Klein commented on patch set 1 CR +1 10/13/14, 19:56

    Looks very reasonable
  3. Stefan Froemken commented on patch set 1 CR +1 V +1 10/13/14, 20:07

    Ah, found it. This is for the options in selectbox.
  4. Stefan Froemken commented on patch set 1 10/13/14, 20:10

    BackendUserGroupRepository.php:24

    I miss a little PhpDoc: @var array()
  5. Christian Kuhn uploaded patch set 2 10/13/14, 20:16

  6. Wouter Wolters voted on patch set 2 CR +1 10/13/14, 20:17

  7. Christian Kuhn voted on patch set 2 CR +2 V +2 10/13/14, 20:17

  8. Georg Ringer merged patch set 2 10/13/14, 20:17

  9. Georg Ringer commented on patch set 3 10/13/14, 20:18

    Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit d4f7028d454fb382db4302195fd555f30fb5350f