Review main Merged

33302[BUGFIX] jsfunc.inline is not fully jQuery compatible

Stefan Froemken CR +2 V +2 Normal +68 −65 updated 10/20/14, 20:50

Commit message

When working with TYPO3.jQuery you don't get the object itself,
it returns a jQuery object which contains the mentioned object
at array ID 0.

 * To differ jQuery and JS objects I will add $ to jQuery vars.
 * When using jQuery vars, we should also use jQuery methods

Review

  • Code review CR +2
    • Markus Klein +2
    • Benni Mack +1
  • Verified V +2
    • Markus Klein +2
    • Benni Mack +1

Issues 1

Files 1

Review log 11

  1. Stefan Froemken uploaded patch set 1 10/13/14, 21:41

  2. Wouter Wolters updated the commit message in patch set 2 10/14/14, 16:50

  3. Stefan Froemken uploaded patch set 3 10/14/14, 18:10

  4. Markus Klein updated the commit message in patch set 4 10/14/14, 18:21

  5. Markus Klein commented on patch set 4 10/14/14, 18:27

    Small grammar issue

    jsfunc.inline.js:840

    Move this to the end of the previous line, no need for a wrap here

    jsfunc.inline.js:1176

    I didn't find
  6. Stefan Froemken uploaded patch set 5 10/14/14, 18:42

  7. Markus Klein voted on patch set 5 CR +1 10/14/14, 18:52

  8. Benni Mack uploaded patch set 6 10/20/14, 19:57

  9. Benni Mack commented on patch set 6 CR +1 V +1 10/20/14, 19:57

    There was a small typo which made the old version not working. v6 works fine!
  10. Markus Klein voted on patch set 6 CR +2 V +2 10/20/14, 20:50

  11. Markus Klein merged patch set 6 10/20/14, 20:50