Review main Abandoned

33306[WIP][TASK] Render input type="number" for eval=num TCA

Christian Kuhn CR 0 V 0 Easy +7 −5 updated 01/30/15, 09:55

Commit message

CSS needs some love, still

Review

  • Code review CR 0
  • Verified V 0

Files 3

Review log 11

  1. Christian Kuhn uploaded patch set 1 10/14/14, 10:25

  2. Felix Kopp commented on patch set 1 10/15/14, 19:19

    Works great! I like the position as well
  3. Christian Kuhn commented on patch set 1 10/17/14, 21:07

    Talked about this one with Felix, will work on it soon.
  4. Felix Kopp wrote 11/02/14, 23:15

    Topic set to formengine
  5. Mathias Schreiber wrote 12/17/14, 15:03

    Topic changed from formengine to Formengine
  6. Mathias Brodala commented on patch set 1 CR -1 12/17/14, 16:06

    InputElement.php:45

    text
  7. Felix Kopp commented on patch set 1 12/18/14, 00:12

    Should I address the css issue?
  8. Christian Kuhn commented on patch set 1 12/18/14, 00:44

    that would be great, felix :)
  9. Mathias Schreiber uploaded patch set 2 12/29/14, 11:42

  10. Mathias Schreiber commented on patch set 2 12/29/14, 11:43

    Here's the problem. The spinner will always show up on the right side. In order to keep the change small, the "clear" icon needs to go to the left. I illustrated the impact with this changeset
  11. Christian Kuhn abandoned the change 01/30/15, 09:55

    Abandoned for now.