Review main Merged

3331[BUGFIX] cli_dispatch.phpsh respects path to php

Markus Bucher CR +2 V +2 Easy +1 −1 updated 06/03/13, 20:49

Commit message

Using '#! /usr/bin/env php' as shebang respects the environment, so
if e.g. /usr/local/bin is in your PATH, this php will be chosen.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Stefan Neufeind +1
    • Andreas Lappe +1
    • Xavier Perseguers +1
    • Philipp Gampe +1
  • Verified V +2
    • Christian Kuhn +2
    • Andreas Lappe +1
    • Xavier Perseguers +1
    • Philipp Gampe +1

Issues 1

Files 1

Review log 10

  1. Andreas Lappe commented on patch set 1 07/16/11, 00:09

    I would prefer that you didn't submit this Please adjust the commit message: Not php -q is used in the patch but just php. Otherwise fine and I'd be happy to finally see it in the core.
  2. Mr. Jenkins commented on patch set 1 07/16/11, 00:09

  3. Stefan Neufeind commented on patch set 2 07/16/11, 00:09

    Looks good to me, but someone else must approve
  4. Xavier Perseguers commented on patch set 2 07/16/11, 00:09

    Verified; Looks good to me, but someone else must approve
  5. Christian Kuhn commented on patch set 2 V 0 07/16/11, 00:09

    by team member; Looks good to me, approved This was also already discussed on the core mailing list with mantis issue 16957 some time ago. I verified my vote again and will merge this patch now.
  6. Andreas Lappe commented on patch set 2 07/16/11, 00:09

    Verified; Looks good to me, but someone else must approve
  7. Philipp Gampe commented on patch set 2 07/16/11, 00:09

    Verified; Looks good to me, but someone else must approve Works for me
  8. Mr. Jenkins commented on patch set 2 07/16/11, 00:09

  9. Markus Bucher uploaded patch set 2 07/16/11, 00:09

  10. Christian Kuhn merged patch set 2 07/16/11, 00:09