Review main Merged

33335[BUGFIX] Handle utf8 strings in TitleCaseFilter

Graeme Worthy CR +2 V +2 Easy +21 −4 updated 10/16/14, 20:44

Commit message

Use proper charset aware string conversion API to handle
the value given to the TitleCaseFilter.

Review

  • Code review CR +2
    • Philipp Gampe +2
    • Markus Klein +1
  • Verified V +2
    • Philipp Gampe +2
    • Markus Klein +1

Issues 1

Files 2

Review log 9

  1. Graeme Worthy uploaded patch set 1 10/16/14, 11:26

  2. Tymoteusz Motylewski updated the commit message in patch set 2 10/16/14, 13:10

  3. Oliver Klee voted on patch set 2 CR +1 10/16/14, 17:52

  4. Markus Klein commented on patch set 2 CR -1 10/16/14, 18:26

    Will push a new patch set.
    The commit message shall be present tense and shall describe the change and not the problem.

    TitleCaseFilter.php:32

    This does not comply with CGL.
  5. Markus Klein uploaded patch set 3 10/16/14, 18:34

  6. Markus Klein voted on patch set 3 CR +1 V +1 10/16/14, 18:34

  7. Philipp Gampe voted on patch set 3 CR +2 V +2 10/16/14, 20:43

  8. Philipp Gampe merged patch set 3 10/16/14, 20:43

  9. Philipp Gampe commented on patch set 4 10/16/14, 20:44

    Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit e623278aecf064ebb4042a3a27bf5e313fd70208