33403[CLEANUP] TSFE: Deprecate JSfuncCalls for body tag
Commit message
Review
-
Code review CR +2
- Wouter Wolters +2
- Markus Klein +1
-
Verified V +2
- Wouter Wolters +2
- Markus Klein +1
Issues 1
Files 3
Review log 9
-
Benni Mack uploaded patch set 1 10/21/14, 06:28
-
Stefan Froemken commented on patch set 1 10/21/14, 07:14
I thought something can only be deactivated after two more releases. So I wonder why you have marked this as deprecated AND deactivated. -
Markus Klein commented on patch set 1 CR -1 10/21/14, 09:06
Deprecation-62363-TSFE-JSfuncCalls.rst:12That does not make much sense, indeed. -
Benni Mack commented on patch set 1 10/21/14, 10:01
Easy, I can only mark a function as deprecated if it is not used in the core anymore. Thus, I have to "not use" it anymore. This is what I meant with "disabled". -
Markus Klein commented on patch set 1 10/21/14, 11:31
Ehm... I understand that differently. We mark something deprecated if the USER shall not use it anymore. In this case, we have the wrong approach IMO. The function we deprecate here is just the "rendering function" for the feature the user shall not use anymore. We must not deprecate this function. We have to deprecate the usage of the feature. In the current situation there is no benefit for anybody. The feature does not work anymore (without deprecation) and the method is completely useless now. -
Markus Klein uploaded patch set 2 10/23/14, 20:57
-
Markus Klein voted on patch set 2 CR +1 V +1 10/23/14, 20:58
-
Wouter Wolters voted on patch set 2 V +2 CR +2 10/23/14, 21:30
-
Wouter Wolters merged patch set 2 10/23/14, 21:30