Review main Merged

3345[BUGFIX] Localization of a constant string is empty

Xavier Perseguers CR +2 V +2 Easy +8 −2 updated 06/03/13, 20:49

Commit message

When using a constant string (e.g., "CSS Styled Content") instead of a
localization key (e.g., "LLL:EXT:some_ext/locallang.xml:key"), the constant
string should be returned instead of an empty string.

Review

  • Code review CR +2
    • Xavier Perseguers +2
    • Dominique Feyer +1
    • Philipp Gampe +1
  • Verified V +2
    • Xavier Perseguers +2
    • Dominique Feyer +1
    • Philipp Gampe +1

Files 1

Review log 5

  1. Xavier Perseguers commented on patch set 1 V 0 07/15/11, 09:38

    by team member; Looks good to me, approved
  2. Philipp Gampe commented on patch set 1 07/15/11, 09:38

    Verified; Looks good to me, but someone else must approve Works for me with mentioned problem in issue tracker
  3. Dominique Feyer commented on patch set 1 07/15/11, 09:38

    Verified; Looks good to me, but someone else must approve
  4. Mr. Jenkins commented on patch set 1 07/15/11, 09:38

  5. Xavier Perseguers merged patch set 1 07/15/11, 09:38