33469[FEATURE] Base Buttons on Bootstrap - with compat layer
Commit message
Review
-
Code review CR +2
- Wouter Wolters +2
- Ingo Pfennigstorf +1
-
Verified V +2
- Wouter Wolters +2
- Ingo Pfennigstorf +1
Files 3
Review log 11
-
Felix Kopp uploaded patch set 1 10/22/14, 09:59
-
Georg Ringer voted on patch set 1 V +1 CR +1 10/22/14, 14:08
-
Wouter Wolters voted on patch set 1 V +1 CR +1 10/22/14, 17:00
-
Ingo Pfennigstorf commented on patch set 1 10/22/14, 20:44
Bootstrap base is ok. The buttons do not yet really fit into the scheme due to the massive rounded borders. Suggestion: decrease the border radius to 2px or (even better) to 0. -
Felix Kopp commented on patch set 1 10/22/14, 23:00
I think the radius for buttons / primary actions is okay in order to differentiate tab style / input style / module style. If we reduce the radius another style has to emerge: gradient or strong outline or something else. Don't you think? Also this is a hybrid patch: styling + clean-up / base on bootstrap. I think that patch is ready to go - but let us discuss styles on slack/forge. -
Felix Kopp uploaded patch set 2 10/23/14, 09:01
-
Felix Kopp commented on patch set 1 10/23/14, 09:01
Changed to 2px :) -
Wouter Wolters voted on patch set 2 V +1 CR +1 10/23/14, 09:02
-
Ingo Pfennigstorf voted on patch set 2 CR +1 V +1 10/23/14, 19:22
-
Wouter Wolters voted on patch set 2 V +2 CR +2 10/23/14, 19:32
-
Wouter Wolters merged patch set 2 10/23/14, 19:32