3347[BUGFIX] Improve usability of group fields
Commit message
Review
-
Code review CR +2
- Xavier Perseguers +2
- Andreas Wolf +2
- Stefan Neufeind +1
-
Verified V +2
- Andreas Wolf +2
Issues 1
Files 1
Review log 9
-
Andreas Wolf commented on patch set 2 09/20/11, 10:30
I would prefer that you didn't submit this The problem is that it's not clear for TYPO3 which file to delete if you have uploaded more than one. In this case the delete button removes all files (!). Is this the intended behaviour? I would rather suggest to display the list as long as not both the move controls and the delete button are hidden. -
Stefan Geith uploaded patch set 2 09/20/11, 10:30
-
Stefan Geith commented on patch set 2 09/20/11, 10:30
IF you set (manually) to NOT display the list, the (at least for me) it seems clear, that with 'delete', the whole list is cleared. Its up to the developpers to set the right values in TCA, so if you set this with maxitmes>1, you have to know, that delete will delete all files. -
Stefan Neufeind commented on patch set 2 09/20/11, 10:30
Looks good to me, but someone else must approve -
Xavier Perseguers commented on patch set 2 09/20/11, 10:30
Looks good to me, approved -
Mr. Jenkins commented on patch set 1 09/20/11, 10:30
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/1177/ : SUCCESS -
Mr. Jenkins commented on patch set 2 09/20/11, 10:30
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/1178/ : SUCCESS -
Andreas Wolf commented on patch set 2 V 0 09/20/11, 10:30
by team member; Looks good to me, approved I revoke my -1 and push this after a positive review - thought about it some more, and now I support this change. -
Andreas Wolf merged patch set 2 09/20/11, 10:30