3355[BUGFIX] Chained stdWrap is broken for boolean stdWrap function types
Commit message
Review
-
Code review CR +2
- Xavier Perseguers +2
- Stefan Neufeind +1
- Jo Hasenau +1
- Philipp Gampe +1
-
Verified V +2
- Xavier Perseguers +2
- Stefan Neufeind +1
- Jo Hasenau +1
- Philipp Gampe +1
Issues 1
Files 1
Review log 14
-
Stefan Neufeind commented on patch set 2 07/24/11, 10:19
Verified; Looks good to me, but someone else must approve and be sure to fetch code from https://review.typo3.org/#change,2585 before testing, after that cherry-pick this one here :-) works -
Stefan Neufeind commented on patch set 2 07/24/11, 10:19
suggestion came up to maybe turn the testcases mentioned in the comments into unittests. So if somebody wants to jump at it ... Otherwise I might try to do that later today maybe. -
Stefan Neufeind uploaded patch set 2 07/24/11, 10:19
-
Stefan Neufeind commented on patch set 2 07/24/11, 10:19
Jenkins complaint about an "else if" which should have been "elseif" ... good Jenkins :-) -
Xavier Perseguers commented on patch set 2 V 0 07/24/11, 10:19
by team member; Looks good to me, approved -
Philipp Gampe commented on patch set 2 07/24/11, 10:19
Verified; Looks good to me, but someone else must approve Ok, got it now. -
Philipp Gampe commented on patch set 2 07/24/11, 10:19
I tried it with 10 = TEXT 10.value = 2-4,5,6,3-9,8 10.expandList = 1 10.expandList { if.field = pid if.negate = 0 } again (on top of the expandList patch). It still does not work. The list is always expanded. Is my testing TS wrong? -
Jo Hasenau commented on patch set 2 07/24/11, 10:19
Depends on the scope of $cObj->data though, since field = pid might return different values. So it will work on page 123 as long as you implement it together with the rendering of a tt_content element. Otherwise pid would not be the page id but the id of the parent page. -
Jo Hasenau commented on patch set 2 07/24/11, 10:19
Can someone please take care of this, since it will be essential to test other new stdWrap functions. Thx -
Jo Hasenau commented on patch set 2 07/24/11, 10:19
Again: "if" hasn't got any "field" property. So try these: 10 = TEXT 10.value = 2-4,5,6,3-9,8 10.expandList = 1 10.expandList { if.value = 123 if.equals.field = pid } 20 = TEXT 20.value = 2-4,5,6,3-9,8 20.expandList = 1 20.expandList { if.value = 123 if.equals.field = pid if.negate = 1 } The first one should be working on page 123, the second one on all other pages. -
Jo Hasenau commented on patch set 2 07/24/11, 10:19
Verified; Looks good to me, but someone else must approve -
Mr. Jenkins commented on patch set 1 07/24/11, 10:19
Fails; I would prefer that you didn't submit this Build Failed http://ci.typo3.org/job/typo3-v4-core-gerrit/1186/ : FAILURE -
Mr. Jenkins commented on patch set 2 07/24/11, 10:19
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/1188/ : SUCCESS -
Xavier Perseguers merged patch set 2 07/24/11, 10:19