Review main Merged

33573[BUGFIX] Only reload pagetree if pages are changed

Helmut Hummel CR +2 V +2 Easy +8 −4 updated 10/28/14, 07:23

Commit message

When using the click menu to hide, unhide or delete
a record, previously the page tree was refreshed,
although those changes are only reflected in the
pagetree if page properties are changed.

Adapt the click menu to only refresh the tree
if a page record is changed or deleted.

Review

  • Code review CR +2
    • Frank Nägler +2
    • Christian Kuhn +1
  • Verified V +2
    • Frank Nägler +2
    • Christian Kuhn +1

Issues 1

Files 1

Review log 18

  1. Helmut Hummel uploaded patch set 1 10/27/14, 16:04

  2. Helmut Hummel updated the commit message in patch set 2 10/27/14, 16:07

  3. Frank Nägler voted on patch set 2 V +1 CR +1 10/27/14, 16:11

  4. Markus Klein commented on patch set 2 10/27/14, 16:14

    Does that also work if you have the same db mount twice?
  5. Christian Kuhn voted on patch set 2 CR +1 V +1 10/27/14, 16:32

  6. Markus Klein commented on patch set 2 CR -2 10/27/14, 17:02

    Please answer my question
  7. Markus Klein commented on patch set 2 V -1 CR -1 10/27/14, 17:15

    Answering myself: No it does not work. Testcase: normal BE user, page1->page2, db mounts page1,page2; hiding page2 only refreshs one mount
  8. Markus Klein commented on patch set 2 CR 0 V 0 10/27/14, 17:24

    taking back my vote. does not work without the patch either...
  9. Markus Klein commented on patch set 2 10/27/14, 17:25

    more info: I used the clickmenu of the pagetree!
  10. Christian Kuhn commented on patch set 2 CR +2 V +2 10/27/14, 17:50

    @Markus: Thanks for verifying this bug. But since this patch here does not introduce it, I guess it is fine. The constant reloading of the pagetree is annoying, so this patch is a nice improvement.
  11. Christian Kuhn voted on patch set 2 CR +1 V +1 10/27/14, 17:50

  12. Christian Kuhn updated the commit message in patch set 3 10/27/14, 17:50

  13. Christian Kuhn voted on patch set 3 CR +1 V +1 10/27/14, 17:50

  14. Helmut Hummel commented on patch set 3 10/27/14, 18:02

    @Markus: This change is not at all about the context menu of the page tree. no changes are done in this are. It is only about the "traditional" context menu (ClickMenu) you get when you click on a record icon (e.g. in list view). There hiding an arbitrary record (not a page) triggers a js reload of the complete page tree, which makes no sense. This change is about checking if the action is done on the "pages" table and only trigger a refresh of the page tree in this case.
  15. Frank Nägler voted on patch set 3 V +2 CR +2 10/27/14, 18:50

  16. Frank Nägler merged patch set 3 10/27/14, 18:50

  17. Frank Nägler commented on patch set 4 10/27/14, 18:51

    Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit c23f5adf50399bdc03f15e8b323db943db928306
  18. Stefan Neufeind commented on patch set 4 10/28/14, 07:23

    post +1. Great, thanks.