33588[CLEANUP] Remove unnecessary fully qualified names
Commit message
Review
-
Code review CR +2
- Markus Klein +2
- Stefan Froemken +1
-
Verified V +2
- Markus Klein +2
- Stefan Froemken +1
Issues 1
Files 14
- typo3/sysext/core/Classes/Utility/File/ExtendedFileUtility.php+26 −19
- typo3/sysext/core/Classes/Utility/File/ExtendedFileUtilityProcessDataHookInterface.php+1 −1
- typo3/sysext/core/Classes/Utility/ArrayUtility.php2+1 −1
- typo3/sysext/core/Classes/Utility/ClientUtility.php+1 −1
- typo3/sysext/core/Classes/Utility/CommandUtility.php+2 −2
- typo3/sysext/core/Classes/Utility/DebugUtility.php+3 −3
- typo3/sysext/core/Classes/Utility/DiffUtility.php+8 −8
- typo3/sysext/core/Classes/Utility/ExtensionManagementUtility.php+10 −8
- typo3/sysext/core/Classes/Utility/GeneralUtility.php+33 −29
- typo3/sysext/core/Classes/Utility/HttpUtility.php+1 −1
- typo3/sysext/core/Classes/Utility/MonitorUtility.php+3 −3
- typo3/sysext/core/Classes/Utility/PathUtility.php+1 −1
- typo3/sysext/core/Classes/Utility/RootlineUtility.php+12 −10
- typo3/sysext/core/Classes/Utility/VersionNumberUtility.php+15 −15
Review log 11
-
Frank Nägler uploaded patch set 1 10/27/14, 21:18
-
Stefan Froemken voted on patch set 1 CR +1 10/27/14, 21:32
-
Wouter Wolters commented on patch set 1 V +1 CR +1 10/27/14, 21:38
Closely checked the change and ran the unit-tests -
Markus Klein uploaded patch set 2 10/27/14, 22:55
-
Markus Klein voted on patch set 2 CR +1 V +1 10/27/14, 22:56
-
Stefan Froemken commented on patch set 2 CR +1 V +1 10/28/14, 07:18
It works, but phpUnit fails at addPluginThrowsExceptionForMissingExtkey. After switching back to master it still fails, so some other patch implements this failure. -
Markus Klein voted on patch set 2 CR +2 V +2 10/28/14, 15:39
-
Markus Klein merged patch set 2 10/28/14, 15:40
-
Stanislas Rolland commented on patch set 3 10/30/14, 04:20
This change broke ArrayUtility::filterByValueRecursive in PHP 5.3.27ArrayUtility.php:65This does not work in PHP 5.3.27. You need ArrayUtility::filterByValueRecursive -
Wouter Wolters commented on patch set 3 10/30/14, 07:41
Stanislas: Current master requires PHP 5.5 of higher. This was decided on the last Active Contributors Meeting. See the protocol of decisions here: http://wiki.typo3.org/TYPO3.CMS/Protocols/T3ACME14MUC#PHP