Review main Merged

33588[CLEANUP] Remove unnecessary fully qualified names

Frank Nägler CR +2 V +2 Normal +117 −102 updated 10/30/14, 07:41

Commit message

Remove unnecessary fully qualified names from Utility classes.

Review

  • Code review CR +2
    • Markus Klein +2
    • Stefan Froemken +1
  • Verified V +2
    • Markus Klein +2
    • Stefan Froemken +1

Issues 1

Files 14

Review log 11

  1. Frank Nägler uploaded patch set 1 10/27/14, 21:18

  2. Stefan Froemken voted on patch set 1 CR +1 10/27/14, 21:32

  3. Wouter Wolters commented on patch set 1 V +1 CR +1 10/27/14, 21:38

    Closely checked the change and ran the unit-tests
  4. Markus Klein commented on patch set 1 10/27/14, 22:54

    lowercase

    ArrayUtility.php:65

    static
  5. Markus Klein uploaded patch set 2 10/27/14, 22:55

  6. Markus Klein voted on patch set 2 CR +1 V +1 10/27/14, 22:56

  7. Stefan Froemken commented on patch set 2 CR +1 V +1 10/28/14, 07:18

    It works, but phpUnit fails at addPluginThrowsExceptionForMissingExtkey. After switching back to master it still fails, so some other patch implements this failure.
  8. Markus Klein voted on patch set 2 CR +2 V +2 10/28/14, 15:39

  9. Markus Klein merged patch set 2 10/28/14, 15:40

  10. Stanislas Rolland commented on patch set 3 10/30/14, 04:20

    This change broke ArrayUtility::filterByValueRecursive in PHP 5.3.27

    ArrayUtility.php:65

    This does not work in PHP 5.3.27. You need ArrayUtility::filterByValueRecursive
  11. Wouter Wolters commented on patch set 3 10/30/14, 07:41

    Stanislas: Current master requires PHP 5.5 of higher. This was decided on the last Active Contributors Meeting. See the protocol of decisions here: http://wiki.typo3.org/TYPO3.CMS/Protocols/T3ACME14MUC#PHP