Review main Merged

33615[BUGFIX] Fix access to empty ObjectStorage with numeric key

Mathias Brodala CR +2 V +2 Easy +17 −1 updated 11/21/14, 09:53

Commit message

This prevents a warning error triggered by spl_object_hash being called
with an integer/string and can be caused by Fluid like this:

{object.relations.0}

Review

  • Code review CR +2
    • Markus Klein +2
    • Mathias Schreiber +1
  • Verified V +2
    • Markus Klein +2
    • Mathias Schreiber +1

Issues 1

Files 2

Review log 8

  1. Mathias Brodala uploaded patch set 1 10/30/14, 10:44

  2. Mathias Brodala commented on patch set 1 11/21/14, 07:56

    Anyone care to review and merge this?
  3. Markus Klein updated the commit message in patch set 2 11/21/14, 09:27

  4. Markus Klein commented on patch set 2 CR +1 V +1 11/21/14, 09:28

    Good catch! thx.
  5. Mathias Schreiber voted on patch set 2 CR +1 V +1 11/21/14, 09:29

  6. Markus Klein voted on patch set 2 CR +2 V +2 11/21/14, 09:53

  7. Markus Klein merged patch set 2 11/21/14, 09:53

  8. Markus Klein commented on patch set 3 11/21/14, 09:53

    Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit 171ed48aa78d443050f92bee22d0d0a74f8df89b