Review main Merged

33616[TASK] Add unit test for short data type support in ReflectionService

Markus Klein CR +2 V +2 Easy +37 −1 updated 12/10/17, 10:56

Commit message

Review

  • Code review CR +2
    • Markus Klein +2
    • Oliver Klee +1
    • Wouter Wolters +1
  • Verified V +2
    • Markus Klein +2
    • Wouter Wolters +1

Issues 1

Files 1

Review log 9

  1. Markus Klein uploaded patch set 1 10/30/14, 11:01

  2. Wouter Wolters voted on patch set 1 V +1 CR +1 10/30/14, 11:46

  3. Oliver Klee commented on patch set 1 CR +1 10/30/14, 13:29

    ReflectionServiceTest.php:111

    I'd generally prefer assertSame as this checks in a stricter way.
  4. Markus Klein commented on patch set 1 10/30/14, 17:36

    ReflectionServiceTest.php:111 Reply

    I agree, but I just copied this from above ;-)
  5. Markus Klein uploaded patch set 2 10/30/14, 17:38

  6. Oliver Klee voted on patch set 2 CR +1 10/30/14, 17:39

  7. Wouter Wolters voted on patch set 2 V +1 CR +1 10/30/14, 19:57

  8. Markus Klein voted on patch set 2 CR +2 V +2 10/30/14, 20:25

  9. Markus Klein merged patch set 2 10/30/14, 20:25