33632[TASK] Use "int" or "bool" in @var notation
Commit message
Review
-
Code review CR +2
- Markus Klein +2
- Frank Nägler +1
-
Verified V +2
- Markus Klein +2
- Frank Nägler +1
Issues 1
Files 224
- typo3/sysext/backend/Classes/Controller/ContentElement/ElementInformationController.php+1 −1
- typo3/sysext/backend/Classes/Form/Element/SuggestDefaultReceiver.php+1 −1
- typo3/sysext/backend/Classes/Form/FormDataTraverser.php+2 −2
- typo3/sysext/backend/Classes/Form/FormEngine.php+2 −2
- typo3/sysext/backend/Classes/Search/LiveSearch/LiveSearch.php+5 −5
- typo3/sysext/backend/Classes/Sprite/SpriteGenerator.php+8 −8
- typo3/sysext/backend/Classes/Template/DocumentTemplate.php+2 −2
- typo3/sysext/backend/Classes/Tree/Pagetree/Commands.php+4 −4
- typo3/sysext/backend/Classes/Tree/Pagetree/DataProvider.php+2 −2
- typo3/sysext/backend/Classes/Tree/Pagetree/PagetreeNode.php+3 −3
- typo3/sysext/backend/Classes/Tree/Renderer/ExtJsJsonTreeRenderer.php+1 −1
- typo3/sysext/backend/Classes/Tree/Renderer/UnorderedListTreeRenderer.php+1 −1
- typo3/sysext/backend/Classes/Tree/View/FolderTreeView.php+1 −1
- typo3/sysext/backend/Classes/Tree/ExtDirectNode.php+8 −8
- typo3/sysext/backend/Classes/View/BackendLayout/DataProviderContext.php+1 −1
- typo3/sysext/backend/Classes/View/PageLayoutView.php+1 −1
- typo3/sysext/backend/Classes/FrontendBackendUserAuthentication.php+3 −3
- typo3/sysext/belog/Classes/Controller/AbstractController.php+9 −9
- typo3/sysext/belog/Classes/Domain/Model/Constraint.php+10 −10
- typo3/sysext/belog/Classes/Domain/Model/LogEntry.php+11 −11
Show 204 more files
- typo3/sysext/belog/Classes/Domain/Model/Workspace.php+2 −2
- typo3/sysext/beuser/Classes/Domain/Model/Demand.php+10 −10
- typo3/sysext/core/Classes/Cache/Backend/AbstractBackend.php+1 −1
- typo3/sysext/core/Classes/Cache/Backend/FileBackend.php+1 −1
- typo3/sysext/core/Classes/Cache/Backend/RedisBackend.php+6 −6
- typo3/sysext/core/Classes/Cache/Backend/SimpleFileBackend.php+2 −2
- typo3/sysext/core/Classes/Cache/Backend/Typo3DatabaseBackend.php+4 −4
- typo3/sysext/core/Classes/Cache/Frontend/VariableFrontend.php+1 −1
- typo3/sysext/core/Classes/Cache/Cache.php+1 −1
- typo3/sysext/core/Classes/Collection/AbstractRecordCollection.php+1 −1
- typo3/sysext/core/Classes/Database/DatabaseConnection.php+4 −4
- typo3/sysext/core/Classes/Database/PreparedStatement.php+8 −8
- typo3/sysext/core/Classes/Database/RelationHandler.php+6 −6
- typo3/sysext/core/Classes/DataHandling/DataHandler.php+23 −23
- typo3/sysext/core/Classes/Imaging/GraphicalFunctions.php+1 −1
- typo3/sysext/core/Classes/Integrity/DatabaseIntegrityCheck.php+3 −3
- typo3/sysext/core/Classes/Localization/LocalizationFactory.php+1 −1
- typo3/sysext/core/Classes/Locking/Locker.php+4 −4
- typo3/sysext/core/Classes/Log/Processor/AbstractMemoryProcessor.php+2 −2
- typo3/sysext/core/Classes/Log/Processor/IntrospectionProcessor.php+1 −1
- typo3/sysext/core/Classes/Log/Writer/SyslogWriter.php+1 −1
- typo3/sysext/core/Classes/Log/Logger.php+1 −1
- typo3/sysext/core/Classes/Log/LogLevel.php+8 −8
- typo3/sysext/core/Classes/Log/LogRecord.php+1 −1
- typo3/sysext/core/Classes/Mail/MailMessage.php+1 −1
- typo3/sysext/core/Classes/Mail/Rfc822AddressesParser.php+3 −3
- typo3/sysext/core/Classes/Messaging/AbstractMessage.php+1 −1
- typo3/sysext/core/Classes/Messaging/FlashMessage.php+1 −1
- typo3/sysext/core/Classes/Package/FailsafePackageManager.php+1 −1
- typo3/sysext/core/Classes/Page/PageRenderer.php+22 −22
- typo3/sysext/core/Classes/Resource/Driver/AbstractDriver.php+2 −2
- typo3/sysext/core/Classes/Resource/Filter/FileNameFilter.php+1 −1
- typo3/sysext/core/Classes/Resource/Index/Indexer.php+1 −1
- typo3/sysext/core/Classes/Resource/Processing/AbstractTask.php+2 −2
- typo3/sysext/core/Classes/Resource/AbstractFile.php+1 −1
- typo3/sysext/core/Classes/Resource/File.php+1 −1
- typo3/sysext/core/Classes/Resource/ProcessedFile.php+1 −1
- typo3/sysext/core/Classes/Resource/ResourceStorage.php+3 −3
- typo3/sysext/core/Classes/Tree/TableConfiguration/AbstractTableConfigurationTreeDataProvider.php+2 −2
- typo3/sysext/core/Classes/Tree/TableConfiguration/DatabaseTreeDataProvider.php+2 −2
- typo3/sysext/core/Classes/Tree/TableConfiguration/DatabaseTreeNode.php+4 −4
- typo3/sysext/core/Classes/TypoScript/TemplateService.php+4 −4
- typo3/sysext/core/Classes/Utility/CommandUtility.php+1 −1
- typo3/sysext/core/Classes/Utility/ExtensionManagementUtility.php+1 −1
- typo3/sysext/core/Classes/Utility/RootlineUtility.php+4 −4
- typo3/sysext/core/Tests/Functional/Category/Collection/CategoryCollectionTest.php+1 −1
- typo3/sysext/core/Tests/Functional/DataHandling/IRRE/AbstractTestCase.php+1 −1
- typo3/sysext/core/Tests/Unit/Core/ClassLoaderTest.php+1 −1
- typo3/sysext/core/Tests/BaseTestCase.php+2 −2
- typo3/sysext/extbase/Classes/Configuration/BackendConfigurationManager.php+1 −1
- typo3/sysext/extbase/Classes/Domain/Model/BackendUser.php1+3 −3
- typo3/sysext/extbase/Classes/Domain/Model/BackendUserGroup.php+3 −3
- typo3/sysext/extbase/Classes/Domain/Model/FileMount.php+1 −1
- typo3/sysext/extbase/Classes/DomainObject/AbstractDomainObject.php+1 −1
- typo3/sysext/extbase/Classes/Error/Result.php+3 −3
- typo3/sysext/extbase/Classes/Mvc/Cli/CommandArgumentDefinition.php+1 −1
- typo3/sysext/extbase/Classes/Mvc/Cli/Request.php+1 −1
- typo3/sysext/extbase/Classes/Mvc/Cli/Response.php+1 −1
- typo3/sysext/extbase/Classes/Mvc/Controller/Argument.php+1 −1
- typo3/sysext/extbase/Classes/Mvc/Web/Routing/UriBuilder.php+7 −7
- typo3/sysext/extbase/Classes/Mvc/Web/Request.php+1 −1
- typo3/sysext/extbase/Classes/Mvc/Web/Response.php+1 −1
- typo3/sysext/extbase/Classes/Mvc/Request.php+1 −1
- typo3/sysext/extbase/Classes/Object/Container/ClassInfo.php+2 −2
- typo3/sysext/extbase/Classes/Persistence/Generic/Qom/Comparison.php+1 −1
- typo3/sysext/extbase/Classes/Persistence/Generic/Qom/Join.php+1 −1
- typo3/sysext/extbase/Classes/Persistence/ObjectStorage.php+2 −2
- typo3/sysext/extbase/Classes/Property/TypeConverter/AbstractFileCollectionConverter.php+1 −1
- typo3/sysext/extbase/Classes/Property/TypeConverter/AbstractFileFolderConverter.php+1 −1
- typo3/sysext/extbase/Classes/Property/TypeConverter/AbstractTypeConverter.php+1 −1
- typo3/sysext/extbase/Classes/Property/TypeConverter/ArrayConverter.php+1 −1
- typo3/sysext/extbase/Classes/Property/TypeConverter/BooleanConverter.php+1 −1
- typo3/sysext/extbase/Classes/Property/TypeConverter/CoreTypeConverter.php+1 −1
- typo3/sysext/extbase/Classes/Property/TypeConverter/DateTimeConverter.php+1 −1
- typo3/sysext/extbase/Classes/Property/TypeConverter/FloatConverter.php+1 −1
- typo3/sysext/extbase/Classes/Property/TypeConverter/IntegerConverter.php+1 −1
- typo3/sysext/extbase/Classes/Property/TypeConverter/ObjectConverter.php+3 −3
- typo3/sysext/extbase/Classes/Property/TypeConverter/ObjectStorageConverter.php+1 −1
- typo3/sysext/extbase/Classes/Property/TypeConverter/PersistentObjectConverter.php+3 −3
- typo3/sysext/extbase/Classes/Property/TypeConverter/StringConverter.php+1 −1
- typo3/sysext/extbase/Classes/Property/PropertyMappingConfiguration.php+2 −2
- typo3/sysext/extbase/Classes/Reflection/ClassSchema.php+2 −2
- typo3/sysext/extbase/Classes/Reflection/ReflectionService.php+3 −3
- typo3/sysext/extbase/Classes/SignalSlot/Dispatcher.php+1 −1
- typo3/sysext/extbase/Classes/Utility/DebuggerUtility.php+1 −1
- typo3/sysext/extbase/Classes/Validation/Validator/AbstractValidator.php+1 −1
- typo3/sysext/extbase/Classes/Validation/Validator/NotEmptyValidator.php+1 −1
- typo3/sysext/extbase/Tests/Unit/Object/Container/Fixtures/ContainerConstructorInjectionTestFixtures.php+1 −1
- typo3/sysext/extbase/Tests/Unit/Persistence/Fixture/Model/Entity2.php+1 −1
- typo3/sysext/extbase/Tests/Unit/Persistence/Fixture/Model/Entity3.php+1 −1
- typo3/sysext/extensionmanager/Classes/Domain/Model/Extension.php+7 −7
- typo3/sysext/extensionmanager/Classes/Domain/Model/Mirrors.php+2 −2
- typo3/sysext/extensionmanager/Classes/Domain/Repository/ExtensionRepository.php+1 −1
- typo3/sysext/extensionmanager/Classes/Utility/Importer/ExtensionListUtility.php+2 −2
- typo3/sysext/extensionmanager/Classes/Utility/Repository/Helper.php+3 −3
- typo3/sysext/felogin/Classes/Controller/FrontendLoginController.php+4 −4
- typo3/sysext/fluid/Classes/Core/Compiler/TemplateCompiler.php+1 −1
- typo3/sysext/fluid/Classes/Core/Parser/Interceptor/Escape.php+1 −1
- typo3/sysext/fluid/Classes/Core/Parser/ParsingState.php+1 −1
- typo3/sysext/fluid/Classes/Core/ViewHelper/AbstractViewHelper.php+2 −2
- typo3/sysext/fluid/Classes/Core/ViewHelper/ArgumentDefinition.php+2 −2
- typo3/sysext/fluid/Classes/Core/ViewHelper/TagBuilder.php+1 −1
- typo3/sysext/fluid/Classes/Core/Widget/AbstractWidgetViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Be/Widget/Controller/PaginateController.php+5 −5
- typo3/sysext/fluid/Classes/ViewHelpers/Format/CdataViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Format/DateViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Format/HtmlentitiesDecodeViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Format/HtmlentitiesViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Format/HtmlspecialcharsViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Format/HtmlViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Format/RawViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Format/StripTagsViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Format/UrlencodeViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Widget/Controller/PaginateController.php+3 −3
- typo3/sysext/fluid/Classes/ViewHelpers/CObjectViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/CommentViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/CountViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/CycleViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/SwitchViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/Fluid.php+1 −1
- typo3/sysext/form/Classes/Domain/Factory/JsonToTypoScript.php+2 −2
- typo3/sysext/form/Classes/Domain/Factory/TypoScriptFactory.php+1 −1
- typo3/sysext/form/Classes/Domain/Model/Attribute/AbstractAttribute.php+1 −1
- typo3/sysext/form/Classes/Domain/Model/Attribute/AttributesAttribute.php+1 −1
- typo3/sysext/form/Classes/Domain/Model/Attribute/NameAttribute.php+1 −1
- typo3/sysext/form/Classes/Domain/Model/Element/AbstractElement.php+2 −2
- typo3/sysext/form/Classes/Domain/Model/Element/CheckboxElement.php+1 −1
- typo3/sysext/form/Classes/Domain/Model/Element/RadioElement.php+1 −1
- typo3/sysext/form/Classes/Domain/Model/Json/AbstractJsonElement.php+1 −1
- typo3/sysext/form/Classes/Domain/Model/Content.php+2 −2
- typo3/sysext/form/Classes/Filter/AlphabeticFilter.php+1 −1
- typo3/sysext/form/Classes/Filter/AlphanumericFilter.php+1 −1
- typo3/sysext/form/Classes/Filter/RegExpFilter.php+1 −1
- typo3/sysext/form/Classes/Validation/AbstractValidator.php+1 −1
- typo3/sysext/form/Classes/Validation/AlphabeticValidator.php+1 −1
- typo3/sysext/form/Classes/Validation/AlphanumericValidator.php+1 −1
- typo3/sysext/form/Classes/Validation/BetweenValidator.php+1 −1
- typo3/sysext/form/Classes/Validation/InArrayValidator.php+1 −1
- typo3/sysext/form/Classes/View/Confirmation/Element/AbstractElementView.php+1 −1
- typo3/sysext/form/Classes/View/Confirmation/Element/OptgroupElementView.php+1 −1
- typo3/sysext/form/Classes/View/Form/Element/AbstractElementView.php+1 −1
- typo3/sysext/form/Classes/View/Form/Element/OptgroupElementView.php+1 −1
- typo3/sysext/form/Classes/View/Form/Element/OptionElementView.php+1 −1
- typo3/sysext/form/Classes/View/Mail/Html/Element/AbstractElementView.php+1 −1
- typo3/sysext/form/Classes/View/Mail/Html/Element/OptgroupElementView.php+1 −1
- typo3/sysext/form/Classes/View/Mail/Html/Element/OptionElementView.php+1 −1
- typo3/sysext/form/Classes/View/Mail/Plain/Element/AbstractElementView.php+1 −1
- typo3/sysext/form/Classes/View/Wizard/AbstractWizardView.php+1 −1
- typo3/sysext/form/Classes/ElementCounter.php+1 −1
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php+1 −1
- typo3/sysext/frontend/Classes/Utility/CompressionUtility.php+1 −1
- typo3/sysext/frontend/Classes/View/AdminPanelView.php+2 −2
- typo3/sysext/install/Classes/Configuration/Charset/CoreInternalPreset.php+1 −1
- typo3/sysext/install/Classes/Configuration/Charset/IconvPreset.php+1 −1
- typo3/sysext/install/Classes/Configuration/Charset/MbstringPreset.php+1 −1
- typo3/sysext/install/Classes/Configuration/Context/DevelopmentPreset.php+1 −1
- typo3/sysext/install/Classes/Configuration/Context/ProductionPreset.php+1 −1
- typo3/sysext/install/Classes/Configuration/ExtbaseObjectCache/ApcPreset.php+1 −1
- typo3/sysext/install/Classes/Configuration/ExtbaseObjectCache/DatabasePreset.php+1 −1
- typo3/sysext/install/Classes/Configuration/Image/GraphicsMagickPreset.php+1 −1
- typo3/sysext/install/Classes/Configuration/Image/ImageMagick6Preset.php+1 −1
- typo3/sysext/install/Classes/Configuration/AbstractCustomPreset.php+2 −2
- typo3/sysext/install/Classes/Configuration/AbstractPreset.php+1 −1
- typo3/sysext/install/Classes/Controller/Action/Ajax/ExtensionCompatibilityTester.php+1 −1
- typo3/sysext/install/Classes/Service/SessionService.php+2 −2
- typo3/sysext/install/Classes/Updates/AbstractUpdate.php+1 −1
- typo3/sysext/install/Classes/ViewHelpers/PhpInfoViewHelper.php+1 −1
- typo3/sysext/lang/Classes/Domain/Model/Extension.php+1 −1
- typo3/sysext/lang/Classes/Domain/Model/Language.php+1 −1
- typo3/sysext/lang/Classes/LanguageService.php+1 −1
- typo3/sysext/linkvalidator/Classes/Linktype/InternalLinktype.php+2 −2
- typo3/sysext/linkvalidator/Classes/Report/LinkValidatorReport.php+2 −2
- typo3/sysext/linkvalidator/Classes/Task/ValidatorTask.php+10 −10
- typo3/sysext/perm/Classes/Controller/PermissionModuleController.php+6 −6
- typo3/sysext/recordlist/Classes/RecordList.php+1 −1
- typo3/sysext/reports/Classes/Report/Status/ConfigurationStatus.php+2 −2
- typo3/sysext/reports/Classes/Status.php+1 −1
- typo3/sysext/rsaauth/Classes/Backend/BackendFactory.php+1 −1
- typo3/sysext/rsaauth/Classes/Backend/CommandLineBackend.php+1 −1
- typo3/sysext/rsaauth/Classes/Keypair.php+2 −2
- typo3/sysext/saltedpasswords/Classes/Salt/BlowfishSalt.php+4 −4
- typo3/sysext/saltedpasswords/Classes/Salt/Md5Salt.php+1 −1
- typo3/sysext/saltedpasswords/Classes/Salt/PhpassSalt.php+4 −4
- typo3/sysext/saltedpasswords/Classes/Task/BulkUpdateFieldProvider.php+2 −2
- typo3/sysext/saltedpasswords/Classes/Task/BulkUpdateTask.php+3 −3
- typo3/sysext/saltedpasswords/Classes/Utility/ExtensionManagerConfigurationUtility.php+1 −1
- typo3/sysext/saltedpasswords/Classes/SaltedPasswordService.php+1 −1
- typo3/sysext/scheduler/Classes/Example/SleepTask.php+1 −1
- typo3/sysext/scheduler/Classes/Task/AbstractTask.php+4 −4
- typo3/sysext/scheduler/Classes/Task/FileStorageExtractionTask.php+2 −2
- typo3/sysext/scheduler/Classes/Task/FileStorageIndexingTask.php+1 −1
- typo3/sysext/scheduler/Classes/Task/RecyclerGarbageCollectionAdditionalFieldProvider.php+1 −1
- typo3/sysext/scheduler/Classes/Task/TableGarbageCollectionTask.php+2 −2
- typo3/sysext/scheduler/Classes/Execution.php+5 −5
- typo3/sysext/sys_note/Classes/Domain/Model/SysNote.php+2 −2
- typo3/sysext/t3editor/Classes/T3editor.php+2 −2
- typo3/sysext/tstemplate/Classes/Controller/TypoScriptTemplateInformationModuleFunctionController.php+1 −1
- typo3/sysext/version/Classes/DataHandler/CommandMap.php+1 −1
- typo3/sysext/version/Classes/Dependency/DependencyResolver.php+1 −1
- typo3/sysext/version/Classes/Dependency/ElementEntity.php+2 −2
- typo3/sysext/workspaces/Classes/Controller/AbstractController.php+1 −1
- typo3/sysext/workspaces/Classes/Domain/Model/DatabaseRecord.php+1 −1
- typo3/sysext/workspaces/Classes/Service/GridDataService.php+1 −1
- typo3/sysext/workspaces/Classes/Service/IntegrityService.php+4 −4
Review log 12
-
Wouter Wolters uploaded patch set 1 10/30/14, 18:02
-
Markus Klein voted on patch set 1 CR +1 V +1 10/30/14, 18:52
-
Markus Klein updated the commit message in patch set 2 10/30/14, 18:52
-
Markus Klein voted on patch set 2 CR +1 V +1 10/30/14, 18:53
-
Mathias Brodala commented on patch set 2 10/31/14, 09:13
-
Markus Klein commented on patch set 2 10/31/14, 10:27
@Mathias: *bigsmile*, I can say NOPE. We fixed that with extbase now. https://git.typo3.org/Packages/TYPO3.CMS.git/commit/1fb57fc0bd0ea254b953b2d554850dc8da8f9188 -
Mathias Brodala commented on patch set 2 10/31/14, 14:04
Ah indeed. How does Flow handle this case nowadays? -
Markus Klein commented on patch set 2 10/31/14, 14:07
From our findings (reading the code) we concluded it does not work on Flow yet. -
Frank Nägler uploaded patch set 3 11/01/14, 22:44
-
Frank Nägler commented on patch set 3 V +1 CR +1 11/01/14, 22:45
rebase because merge conflict. verified by code review and run unit tests. -
Markus Klein voted on patch set 3 CR +2 V +2 11/02/14, 10:28
-
Markus Klein merged patch set 3 11/02/14, 10:28
BackendUser.php:30