Review main Merged

33632[TASK] Use "int" or "bool" in @var notation

Wouter Wolters CR +2 V +2 Hard +479 −479 updated 11/02/14, 10:28

Commit message

Use "int" or "bool" in @var notation instead of
"interger" or "boolean".

Review

  • Code review CR +2
    • Markus Klein +2
    • Frank Nägler +1
  • Verified V +2
    • Markus Klein +2
    • Frank Nägler +1

Issues 1

Files 224

Show 204 more files

Review log 12

  1. Wouter Wolters uploaded patch set 1 10/30/14, 18:02

  2. Markus Klein voted on patch set 1 CR +1 V +1 10/30/14, 18:52

  3. Markus Klein updated the commit message in patch set 2 10/30/14, 18:52

  4. Markus Klein voted on patch set 2 CR +1 V +1 10/30/14, 18:53

  5. Mathias Brodala commented on patch set 2 10/31/14, 09:13

    BackendUser.php:30

    Does this still work with the Extbase property mapper? AFAIR are only the long type names supported.
  6. Markus Klein commented on patch set 2 10/31/14, 10:27

    @Mathias: *bigsmile*, I can say NOPE. We fixed that with extbase now. https://git.typo3.org/Packages/TYPO3.CMS.git/commit/1fb57fc0bd0ea254b953b2d554850dc8da8f9188
  7. Mathias Brodala commented on patch set 2 10/31/14, 14:04

    Ah indeed. How does Flow handle this case nowadays?
  8. Markus Klein commented on patch set 2 10/31/14, 14:07

    From our findings (reading the code) we concluded it does not work on Flow yet.
  9. Frank Nägler uploaded patch set 3 11/01/14, 22:44

  10. Frank Nägler commented on patch set 3 V +1 CR +1 11/01/14, 22:45

    rebase because merge conflict. verified by code review and run unit tests.
  11. Markus Klein voted on patch set 3 CR +2 V +2 11/02/14, 10:28

  12. Markus Klein merged patch set 3 11/02/14, 10:28