33650[TASK] Remove usage of the keyword global
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Stefan Neufeind +1
-
Verified V +2
- Christian Kuhn +2
- Stefan Neufeind +1
Issues 1
Files 48
- typo3/sysext/backend/Classes/RecordList/ElementBrowserRecordList.php+2 −3
- typo3/sysext/css_styled_content/Classes/Controller/CssStyledContentController.php+2 −3
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php+11 −14
- typo3/sysext/frontend/Classes/Controller/PageInformationController.php+11 −13
- typo3/sysext/frontend/Classes/Controller/TranslationStatusController.php+21 −24
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php3+1 −0
- typo3/sysext/impexp/Classes/Clickmenu.php+1 −2
- typo3/sysext/impexp/Classes/ImportExport.php+35 −42
- typo3/sysext/indexed_search/Classes/Controller/IndexedPagesController.php+9 −12
- typo3/sysext/indexed_search/Classes/Controller/IndexingStatisticsController.php+3 −4
- typo3/sysext/indexed_search/Classes/Controller/SearchFormController.php+5 −7
- typo3/sysext/indexed_search/Classes/Hook/CrawlerHook.php+0 −1
- typo3/sysext/indexed_search/Classes/Indexer.php+5 −7
- typo3/sysext/lowlevel/Classes/View/ConfigurationView.php+1 −3
- typo3/sysext/lowlevel/Classes/View/DatabaseIntegrityView.php+5 −9
- typo3/sysext/lowlevel/Classes/CleanFlexformCommand.php+0 −1
- typo3/sysext/lowlevel/Classes/DeletedRecordsCommand.php+0 −1
- typo3/sysext/lowlevel/Classes/DoubleFilesCommand.php+1 −2
- typo3/sysext/lowlevel/Classes/LostFilesCommand.php+1 −2
- typo3/sysext/lowlevel/Classes/MissingFilesCommand.php+1 −2
Show 28 more files
- typo3/sysext/lowlevel/Classes/MissingRelationsCommand.php+1 −2
- typo3/sysext/lowlevel/Classes/OrphanRecordsCommand.php+0 −1
- typo3/sysext/lowlevel/Classes/RteImagesCommand.php+1 −2
- typo3/sysext/lowlevel/Classes/SyslogCommand.php+1 −2
- typo3/sysext/lowlevel/Classes/VersionsCommand.php+0 −1
- typo3/sysext/rtehtmlarea/Classes/Controller/FrontendRteController.php+6 −7
- typo3/sysext/rtehtmlarea/Classes/Extension/AboutEditor.php+0 −1
- typo3/sysext/rtehtmlarea/Classes/Extension/BlockElements.php+2 −3
- typo3/sysext/rtehtmlarea/Classes/Extension/CharacterMap.php+0 −1
- typo3/sysext/rtehtmlarea/Classes/Extension/DefaultImage.php+0 −1
- typo3/sysext/rtehtmlarea/Classes/Extension/DefaultInline.php+0 −1
- typo3/sysext/rtehtmlarea/Classes/Extension/DefinitionList.php+0 −1
- typo3/sysext/rtehtmlarea/Classes/Extension/FindReplace.php+0 −1
- typo3/sysext/rtehtmlarea/Classes/Extension/InlineElements.php+2 −3
- typo3/sysext/rtehtmlarea/Classes/Extension/InsertSmiley.php+0 −1
- typo3/sysext/rtehtmlarea/Classes/Extension/RemoveFormat.php+0 −1
- typo3/sysext/rtehtmlarea/Classes/Extension/TableOperations.php+0 −1
- typo3/sysext/rtehtmlarea/Classes/Extension/Typo3Link.php+0 −1
- typo3/sysext/rtehtmlarea/Classes/ContentParser.php+2 −3
- typo3/sysext/rtehtmlarea/Classes/RteHtmlAreaApi.php+3 −6
- typo3/sysext/rtehtmlarea/Classes/RteHtmlAreaBase.php+8 −11
- typo3/sysext/setup/Classes/Controller/SetupModuleController.php+8 −9
- typo3/sysext/sv/Classes/AuthenticationService.php+2 −3
- typo3/sysext/t3skin/ext_tables.php1+14 −15
- typo3/sysext/tstemplate/Classes/Controller/TypoScriptTemplateConstantEditorModuleFunctionController.php4+0 −1
- typo3/sysext/tstemplate/Classes/Controller/TypoScriptTemplateObjectBrowserModuleFunctionController.php+0 −1
- typo3/sysext/workspaces/Classes/Service/AutoPublishService.php+0 −1
- typo3/sysext/workspaces/Classes/Service/StagesService.php+0 −1
Review log 12
-
Wouter Wolters uploaded patch set 1 10/30/14, 23:01
-
Helmut Hummel commented on patch set 1 11/01/14, 15:32
like this change. I only have a few comments so farthis is not breaking at all (unless we touch ext_teables or ext_localconf inclusions, which we should not in this change)TypoScriptFrontendController.php:4206this removal would be breaking however … Maybe we should deprecate the usage of this altogether and schedule the whole method for removal -
Markus Klein commented on patch set 1 11/01/14, 18:54
TypoScriptFrontendController.php:4206ReplyI agree to deprecation. Lets move away from all these include* things -
Stefan Neufeind commented on patch set 1 CR -1 11/02/14, 13:03
great cleanup. Thanks for all the work.needs a ticket-number; #47207 (open since 1 year) fitsTypoScriptFrontendController.php:4206ReplyHow would you solve it different then? I agree we need to keep it for now (to avoid the breakage). -
Helmut Hummel updated the commit message in patch set 2 11/02/14, 15:57
-
Wouter Wolters uploaded patch set 3 11/03/14, 23:00
-
Christian Kuhn commented on patch set 3 CR +1 V +1 11/03/14, 23:18
All in all the patch reads very well and most parts are very obvious and mostly harmless.ext_tables.php:5Uh, this one is especially ugly since all ext_tables.php code is executed in the same context, so an extension loaded afterwards would also have this automatically.TypoScriptTemplateConstantEditorModuleFunctionController.php:87Whats that? keep it for now? -
Stefan Neufeind commented on patch set 3 CR +1 V +1 11/03/14, 23:40
Worked fine for me so far. Haven't been able to run the testsuite yet, though. Imho we should get rid of the global-line Christian mentioned (see inline-comment).TypoScriptTemplateConstantEditorModuleFunctionController.php:87ReplyI also wondered if we need for example tplRow at all. But there are some few references from the outside world. But turning it into $GLOBALS[...] should of course be save. Let's get rid of this global-line as well! -
Wouter Wolters commented on patch set 3 11/04/14, 07:41
TypoScriptTemplateConstantEditorModuleFunctionController.php:87ReplyI would suggest to do that in an follow up. -
Wouter Wolters wrote 11/04/14, 22:12
Topic set to cleanup -
Christian Kuhn commented on patch set 3 CR +2 V +2 11/05/14, 21:50
TypoScriptTemplateConstantEditorModuleFunctionController.php:87Replyyeah, maybe another patch. -
Christian Kuhn merged patch set 3 11/05/14, 21:50