Review main Merged

33650[TASK] Remove usage of the keyword global

Wouter Wolters CR +2 V +2 Hard +165 −234 updated 11/05/14, 21:50

Commit message

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Stefan Neufeind +1
  • Verified V +2
    • Christian Kuhn +2
    • Stefan Neufeind +1

Issues 1

Files 48

Show 28 more files

Review log 12

  1. Wouter Wolters uploaded patch set 1 10/30/14, 23:01

  2. Helmut Hummel commented on patch set 1 11/01/14, 15:32

    like this change. I only have a few comments so far
    this is not breaking at all (unless we touch ext_teables or ext_localconf inclusions, which we should not in this change)

    TypoScriptFrontendController.php:4206

    this removal would be breaking however … Maybe we should deprecate the usage of this altogether and schedule the whole method for removal
  3. Markus Klein commented on patch set 1 11/01/14, 18:54

    TypoScriptFrontendController.php:4206 Reply

    I agree to deprecation. Lets move away from all these include* things
  4. Stefan Neufeind commented on patch set 1 CR -1 11/02/14, 13:03

    great cleanup. Thanks for all the work.
    needs a ticket-number; #47207 (open since 1 year) fits

    TypoScriptFrontendController.php:4206 Reply

    How would you solve it different then? I agree we need to keep it for now (to avoid the breakage).
  5. Helmut Hummel updated the commit message in patch set 2 11/02/14, 15:57

  6. Wouter Wolters uploaded patch set 3 11/03/14, 23:00

  7. Christian Kuhn commented on patch set 3 CR +1 V +1 11/03/14, 23:18

    All in all the patch reads very well and most parts are very obvious and mostly harmless.

    ext_tables.php:5

    Uh, this one is especially ugly since all ext_tables.php code is executed in the same context, so an extension loaded afterwards would also have this automatically.

    TypoScriptTemplateConstantEditorModuleFunctionController.php:87

    Whats that? keep it for now?
  8. Stefan Neufeind commented on patch set 3 CR +1 V +1 11/03/14, 23:40

    Worked fine for me so far. Haven't been able to run the testsuite yet, though. Imho we should get rid of the global-line Christian mentioned (see inline-comment).

    TypoScriptTemplateConstantEditorModuleFunctionController.php:87 Reply

    I also wondered if we need for example tplRow at all. But there are some few references from the outside world. But turning it into $GLOBALS[...] should of course be save. Let's get rid of this global-line as well!
  9. Wouter Wolters commented on patch set 3 11/04/14, 07:41

    TypoScriptTemplateConstantEditorModuleFunctionController.php:87 Reply

    I would suggest to do that in an follow up.
  10. Wouter Wolters wrote 11/04/14, 22:12

    Topic set to cleanup
  11. Christian Kuhn commented on patch set 3 CR +2 V +2 11/05/14, 21:50

    TypoScriptTemplateConstantEditorModuleFunctionController.php:87 Reply

    yeah, maybe another patch.
  12. Christian Kuhn merged patch set 3 11/05/14, 21:50