Review main Merged

33676[BUGFIX] Bring back select field button's functionality

Markus Klein CR +2 V +2 Easy +7 −4 updated 11/01/14, 20:35

Commit message

Fix the missing CSS classes for the up/down/remove buttons of select
fields in FormEngine.

Review

  • Code review CR +2
    • Markus Klein +2
    • Frank Nägler +1
  • Verified V +2
    • Markus Klein +2
    • Frank Nägler +1

Issues 1

Files 1

Review log 13

  1. Markus Klein uploaded patch set 1 10/31/14, 23:37

  2. Markus Klein updated the commit message in patch set 2 10/31/14, 23:38

  3. Markus Klein commented on patch set 2 10/31/14, 23:40

    This is a quick dirty fix. I suggest to merge this and do further improvements to the JS later
  4. Felix Kopp commented on patch set 2 11/01/14, 09:20

    I suggest to (a) add the former CSS classes to *all* new FA-icons or to (b) fix all occurrences without the former CSS classes. I suggest to send the old CSS classes everywhere. Announce that usage of the css classes to identification is discouraged and work on the JS references parallely.
  5. Felix Kopp commented on patch set 2 11/01/14, 09:22

    IconUtility.php:116

    We add the previous classes here by adding: $tagAttributes['class']]
  6. Helmut Hummel commented on patch set 2 11/01/14, 10:52

    IconUtility.php:49

    can't we just add the classes t3-btn t3-btn-moveoption-down for now and change everything to use data attributes later? Maybe even add a comment why these classes are added again. Adding yet another new class does not seem necessary to me
  7. Markus Klein commented on patch set 2 11/01/14, 18:29

    I agree with any short term solution.
  8. Helmut Hummel commented on patch set 2 11/01/14, 20:01

    IconUtility.php:116 Reply

    ?
  9. Helmut Hummel commented on patch set 2 11/01/14, 20:10

    IconUtility.php:103

    removed on purpose?
  10. Helmut Hummel uploaded patch set 3 11/01/14, 20:10

  11. Frank Nägler voted on patch set 3 V +1 CR +1 11/01/14, 20:15

  12. Markus Klein voted on patch set 3 CR +2 V +2 11/01/14, 20:35

  13. Markus Klein merged patch set 3 11/01/14, 20:35