33676[BUGFIX] Bring back select field button's functionality
Commit message
Review
-
Code review CR +2
- Markus Klein +2
- Frank Nägler +1
-
Verified V +2
- Markus Klein +2
- Frank Nägler +1
Issues 1
Files 1
Review log 13
-
Markus Klein uploaded patch set 1 10/31/14, 23:37
-
Markus Klein updated the commit message in patch set 2 10/31/14, 23:38
-
Markus Klein commented on patch set 2 10/31/14, 23:40
This is a quick dirty fix. I suggest to merge this and do further improvements to the JS later -
Felix Kopp commented on patch set 2 11/01/14, 09:20
I suggest to (a) add the former CSS classes to *all* new FA-icons or to (b) fix all occurrences without the former CSS classes. I suggest to send the old CSS classes everywhere. Announce that usage of the css classes to identification is discouraged and work on the JS references parallely. -
Felix Kopp commented on patch set 2 11/01/14, 09:22
IconUtility.php:116We add the previous classes here by adding: $tagAttributes['class']] -
Helmut Hummel commented on patch set 2 11/01/14, 10:52
IconUtility.php:49can't we just add the classes t3-btn t3-btn-moveoption-down for now and change everything to use data attributes later? Maybe even add a comment why these classes are added again. Adding yet another new class does not seem necessary to me -
Markus Klein commented on patch set 2 11/01/14, 18:29
I agree with any short term solution. -
Helmut Hummel commented on patch set 2 11/01/14, 20:01
IconUtility.php:116Reply? -
Helmut Hummel commented on patch set 2 11/01/14, 20:10
IconUtility.php:103removed on purpose? -
Helmut Hummel uploaded patch set 3 11/01/14, 20:10
-
Frank Nägler voted on patch set 3 V +1 CR +1 11/01/14, 20:15
-
Markus Klein voted on patch set 3 CR +2 V +2 11/01/14, 20:35
-
Markus Klein merged patch set 3 11/01/14, 20:35