Review main Merged

33677[FEATURE] Allow row highlight in table.t3-table

Felix Kopp CR +2 V +2 Hard +251 −30 updated 11/01/14, 10:06

Commit message

<table class="t3-table"> is the TYPO3 standard class. Allows
success / danger / warning / info and active on table rows
and table cells.

Also makes use of new table row markup in Report>Services.
This preceedes #62580 since FlashMessages can't be changed.

Test run this patch with EXT: styleguide Table demo markup.

Review

  • Code review CR +2
    • Frank Nägler +2
    • Georg Ringer +1
    • Markus Klein +1
  • Verified V +2
    • Frank Nägler +2
    • Georg Ringer +1
    • Markus Klein +1

Issues 1

Files 3

Review log 8

  1. Felix Kopp uploaded patch set 1 11/01/14, 00:39

  2. Felix Kopp commented on patch set 1 V -1 11/01/14, 00:43

    Breaks configured search paths somehow. If anyone is interested in this issue feel free to take over. I won't work on this anymore
  3. Markus Klein commented on patch set 1 11/01/14, 01:01

    ServicesListReport.php:186

    missing closing " here. that breaks it
  4. Markus Klein uploaded patch set 2 11/01/14, 01:04

  5. Markus Klein voted on patch set 2 CR +1 V +1 11/01/14, 01:04

  6. Georg Ringer voted on patch set 2 V +1 CR +1 11/01/14, 09:00

  7. Frank Nägler voted on patch set 2 V +2 CR +2 11/01/14, 10:06

  8. Frank Nägler merged patch set 2 11/01/14, 10:06