33688[!!!][TASK] Remove SU mode "change to" in EXT:beuser
Commit message
Review
-
Code review CR +2
- Anja Leichsenring +2
- Markus Klein +1
-
Verified V +2
- Anja Leichsenring +2
- Markus Klein +1
Issues 1
Files 5
- typo3/sysext/beuser/Classes/Controller/BackendUserController.php+10 −16
- typo3/sysext/beuser/Classes/ViewHelpers/SwitchUserViewHelper.php2+3 −4
- typo3/sysext/beuser/Resources/Private/Language/locallang.xlf1+2 −2
- typo3/sysext/beuser/Resources/Private/Partials/BackendUser/IndexListRow.html+1 −2
- typo3/sysext/core/Documentation/Changelog/master/Breaking-62595-RemovedChangeToSwitchModeFromBeUser.rst2new+28 −0
Review log 19
-
Andreas Kienast uploaded patch set 1 11/01/14, 12:48
-
Andreas Kienast uploaded patch set 2 11/01/14, 12:52
-
Andreas Kienast uploaded patch set 3 11/01/14, 12:55
-
Frank Nägler commented on patch set 3 CR -1 11/01/14, 13:36
please see my inline commentsPlease add [!!!] because of breaking changeSwitchUserViewHelper.php:30this is a breaking change, other extensions which could use this viewhelper would break. please add a rst-file. -
Wouter Wolters commented on patch set 3 CR -1 11/01/14, 13:39
locallang.xlf:124removing local lang labels is wrong. Older releases of TYPO3 uses this for translations -
Andreas Kienast uploaded patch set 4 11/01/14, 14:05
-
Andreas Kienast updated the commit message in patch set 5 11/01/14, 14:07
-
Helmut Hummel commented on patch set 3 11/01/14, 15:33
SwitchUserViewHelper.php:30Replyit is a breaking change in general. We're removing functionality here. view helper changes in system extensions (besides Fluid) would be fine though, as we at some point agreed that they are private API -
Markus Klein commented on patch set 5 11/01/14, 18:49
I like this change very much. Never knew what the emulate mode was good for and always had to search which was the switch-back button. Especially since the buttons now had the same icon ;-) Therefore I consider this a good UX improvement due to reduction of interface elementsBreaking-62595-RemovedChangeToSwitchModeFromBeUser.rst:2This is NOT a deprecation, we remove it completely! A deprecation would mean that it still works for some time. -
Andreas Kienast commented on patch set 5 11/01/14, 19:15
Breaking-62595-RemovedChangeToSwitchModeFromBeUser.rst:2ReplyOf course, you're right. Will push a patch tomorrow. -
Andreas Kienast uploaded patch set 6 11/02/14, 09:11
-
Anja Leichsenring commented on patch set 6 V +1 11/02/14, 09:22
works nicely. Can we change the tooltip for the button from [switch-back-mode] to 'switch to user' please? The switch back has no value anymore without the other option. -
Andreas Kienast uploaded patch set 7 11/02/14, 09:43
-
Anja Leichsenring commented on patch set 7 CR +1 V +1 11/02/14, 09:53
thank you :) -
Markus Klein uploaded patch set 8 11/02/14, 10:20
-
Markus Klein commented on patch set 8 CR +1 V +1 11/02/14, 10:20
Updated label to uppercase Switch -
Anja Leichsenring voted on patch set 8 CR +1 V +1 11/02/14, 10:20
-
Anja Leichsenring voted on patch set 8 CR +2 V +2 11/02/14, 10:37
-
Anja Leichsenring merged patch set 8 11/02/14, 10:37