Review main Merged

33729[CLEANUP] Add phpDoc to properties in ext:backend/Controller classes

Wouter Wolters CR +2 V +2 Hard +704 −268 updated 11/03/14, 02:53

Commit message

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Markus Klein +1
  • Verified V +2
    • Christian Kuhn +2
    • Markus Klein +1

Issues 1

Files 21

Show 1 more file

Review log 6

  1. Wouter Wolters uploaded patch set 1 11/02/14, 22:27

  2. Christian Kuhn commented on patch set 1 CR -1 11/02/14, 22:38

    ClickMenuController.php:33

    please have the comment next to the annotation: @var int Defines the name of the document object for which to reload the URL.
  3. Christian Kuhn voted on patch set 1 CR 0 11/02/14, 22:43

  4. Christian Kuhn voted on patch set 1 CR +2 V +2 11/02/14, 22:46

  5. Markus Klein commented on patch set 1 CR +1 V +1 11/02/14, 23:49

    ClickMenuController.php:33 Reply

    We have that around many classes this way now. If I recall correctly we have not guideline for this. Would you be fine with keeping it this way? If so, please merge.
  6. Christian Kuhn merged patch set 1 11/03/14, 02:53