Review main Merged

33820[BUGFIX] Page module Quickedit: wizards are broken

Stanislas Rolland CR +2 V +2 Easy +2 −3 updated 11/08/14, 18:22

Commit message

When using Quickedit mode of Page module, the header link and the RTE
wizards are broken.
Backpath is added twice to the wizard urls.

Review

  • Code review CR +2
    • Helmut Hummel +2
    • Wouter Wolters +1
  • Verified V +2
    • Benni Mack +2
    • Helmut Hummel +1

Issues 1

Files 1

Review log 13

  1. Stanislas Rolland uploaded patch set 1 11/05/14, 14:27

  2. Stanislas Rolland wrote 11/05/14, 14:28

    Topic set to FormEngine
  3. Benni Mack voted on patch set 1 CR +1 11/06/14, 09:29

  4. Wouter Wolters voted on patch set 1 CR +1 11/06/14, 09:34

  5. Benni Mack voted on patch set 1 CR +2 11/06/14, 10:35

  6. Benni Mack voted on patch set 1 V +1 11/06/14, 10:35

  7. Helmut Hummel commented on patch set 1 CR -1 11/06/14, 10:43

    FormEngine.php:2624

    not sure what this means for old wizards with 'script' configuration

    FormEngine.php:2628

    … as $url is used here and it will not have a backpath any more
  8. Stanislas Rolland commented on patch set 1 11/06/14, 14:23

    FormEngine.php:2628 Reply

    You're right. Will upload new patch set.
  9. Stanislas Rolland uploaded patch set 2 11/06/14, 14:26

  10. Helmut Hummel voted on patch set 2 CR +2 V +1 11/06/14, 22:24

  11. Wouter Wolters voted on patch set 2 CR +1 11/06/14, 22:25

  12. Benni Mack voted on patch set 2 V +2 11/08/14, 18:22

  13. Benni Mack merged patch set 2 11/08/14, 18:22