33831[!!!][TASK] Remove alternateBgColors option
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Georg Ringer +1
- Stefan Froemken +1
-
Verified V +2
- Christian Kuhn +2
- Georg Ringer +1
- Stefan Froemken +1
Issues 1
Files 7
- typo3/sysext/core/Documentation/Changelog/master/Breaking-53658-RemoveAlternateBgColorsOption.rstnew+27 −0
- typo3/sysext/fluid/Classes/ViewHelpers/Be/TableListViewHelper.php1+8 −3
- typo3/sysext/recordlist/Classes/RecordList/DatabaseRecordList.php+3 −14
- typo3/sysext/recordlist/Classes/RecordList.php+0 −1
- typo3/sysext/t3editor/res/jslib/parse_typoscript/tokenizetyposcript.js+0 −2
- typo3/sysext/t3skin/Resources/Private/Styles/TYPO3/structure/_module_web_list.less+2 −2
- typo3/sysext/t3skin/Resources/Public/Css/visual/t3kin.css+9 −11
Review log 12
-
Wouter Wolters uploaded patch set 1 11/05/14, 18:53
-
Wouter Wolters uploaded patch set 2 11/05/14, 18:57
-
Benni Mack commented on patch set 2 11/05/14, 19:13
I think we need a RsT file here, as this is a deprecation of a pageTSconfig option (and the doc team needs to know). apart from that. let's get it in. -
Wouter Wolters commented on patch set 2 11/05/14, 19:26
Sure wanted to have some feedback first. Was about to ask for feedback. I'm not sure if dropping the parameter in the fluid viewhelper can be done this easily.. -
Georg Ringer commented on patch set 2 V +1 CR -1 11/05/14, 19:29
TableListViewHelper.php:74removing that is breaking. if someone set that property, it will lead to an exception. so also the [!!!] is needed in the commit msg -
Wouter Wolters uploaded patch set 3 11/05/14, 19:50
-
Wouter Wolters commented on patch set 3 11/05/14, 19:51
The documentation for this has been removed already since 6.2. -
Christian Kuhn voted on patch set 3 CR +1 11/05/14, 22:06
-
Georg Ringer voted on patch set 3 CR +1 V +1 11/06/14, 07:21
-
Stefan Froemken voted on patch set 3 CR +1 V +1 11/06/14, 08:22
-
Christian Kuhn voted on patch set 3 CR +2 V +2 11/06/14, 08:33
-
Christian Kuhn merged patch set 3 11/06/14, 08:33