Review main Merged Breaking

33831[!!!][TASK] Remove alternateBgColors option

Wouter Wolters CR +2 V +2 Normal +49 −33 updated 11/06/14, 08:33

Commit message

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Georg Ringer +1
    • Stefan Froemken +1
  • Verified V +2
    • Christian Kuhn +2
    • Georg Ringer +1
    • Stefan Froemken +1

Issues 1

Files 7

Review log 12

  1. Wouter Wolters uploaded patch set 1 11/05/14, 18:53

  2. Wouter Wolters uploaded patch set 2 11/05/14, 18:57

  3. Benni Mack commented on patch set 2 11/05/14, 19:13

    I think we need a RsT file here, as this is a deprecation of a pageTSconfig option (and the doc team needs to know). apart from that. let's get it in.
  4. Wouter Wolters commented on patch set 2 11/05/14, 19:26

    Sure wanted to have some feedback first. Was about to ask for feedback. I'm not sure if dropping the parameter in the fluid viewhelper can be done this easily..
  5. Georg Ringer commented on patch set 2 V +1 CR -1 11/05/14, 19:29

    TableListViewHelper.php:74

    removing that is breaking. if someone set that property, it will lead to an exception. so also the [!!!] is needed in the commit msg
  6. Wouter Wolters uploaded patch set 3 11/05/14, 19:50

  7. Wouter Wolters commented on patch set 3 11/05/14, 19:51

    The documentation for this has been removed already since 6.2.
  8. Christian Kuhn voted on patch set 3 CR +1 11/05/14, 22:06

  9. Georg Ringer voted on patch set 3 CR +1 V +1 11/06/14, 07:21

  10. Stefan Froemken voted on patch set 3 CR +1 V +1 11/06/14, 08:22

  11. Christian Kuhn voted on patch set 3 CR +2 V +2 11/06/14, 08:33

  12. Christian Kuhn merged patch set 3 11/06/14, 08:33