Review main Merged

33873[FEATURE] Restyle and reorder lowlevel>Configuration

Felix Kopp CR +2 V +2 Normal +17 −35 updated 11/09/14, 08:34

Commit message

Restructure search form. Implement Styles.css and remove
inline CSS. Remove cropping of lines. Equalize array tree.

Review

  • Code review CR +2
    • Benni Mack +2
    • Stefan Neufeind +1
    • Christian Kuhn +1
  • Verified V +2
    • Benni Mack +2
    • Stefan Neufeind +1
    • Christian Kuhn +1

Issues 1

Files 4

Review log 6

  1. Felix Kopp uploaded patch set 1 11/07/14, 10:11

  2. Christian Kuhn voted on patch set 1 CR +1 V +1 11/08/14, 23:19

  3. Stefan Neufeind commented on patch set 1 CR +1 V +1 11/09/14, 00:43

    just a small suggestion

    Configuration.html:24

    maybe only show the div if the condition matches? an empty div now has no height anymore in itself and thus doesn't make much sense to display, right?
  4. Stefan Neufeind commented on patch set 1 11/09/14, 00:45

    Out of curiosity: Why did you remove the cropping? Do you assume that nobody used it or so?
  5. Benni Mack voted on patch set 1 CR +2 V +2 11/09/14, 08:34

  6. Benni Mack merged patch set 1 11/09/14, 08:34