3388[BUGFIX] Unit test checkDateWithInvalidDateValues fails with PHP warning
Commit message
Review
-
Code review CR +2
- Helmut Hummel +2
- Stefan Neufeind +1
-
Verified V +2
- Helmut Hummel +2
- Stefan Neufeind +1
Issues 1
Files 1
Review log 6
-
Stefan Neufeind commented on patch set 1 07/17/11, 19:57
Why not better just cast the values to int "cleanly"? -
Stefan Neufeind commented on patch set 1 07/17/11, 19:57
Verified; Looks good to me, but someone else must approve You are right, it wouldn't return FALSE (but not an exception actually). Tested and works fine. For others: Test in in the scheduler-testsuite. -
Steffen Gebert commented on patch set 1 07/17/11, 19:57
Then all parameters end up with 0 and mktime() accepts them (but doesn't throw the exception) -
Mr. Jenkins commented on patch set 1 07/17/11, 19:57
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/1222/ : SUCCESS -
Helmut Hummel commented on patch set 1 V 0 07/17/11, 19:57
by team member; Looks good to me, approved -
Helmut Hummel merged patch set 1 07/17/11, 19:57