33891[TASK] Cleanup Lowlevel DatabaseIntegrityView
Commit message
Review
-
Code review CR +2
- Benni Mack +2
- Christian Kuhn +1
-
Verified V +2
- Benni Mack +2
- Christian Kuhn +1
Issues 1
Files 1
Review log 11
-
Wouter Wolters uploaded patch set 1 11/07/14, 18:51
-
Christian Kuhn commented on patch set 1 CR +1 V +1 11/08/14, 14:58
Thx. Pretty no-brainish: $this->menu is used nowhere else and the "func" menu is created in getFuncMenu() -
Wouter Wolters commented on patch set 1 11/08/14, 14:59
DatabaseIntegrityView.php:232$funcMenu is not defined if the check is not true.. -
Christian Kuhn commented on patch set 1 CR 0 V 0 11/08/14, 15:14
DatabaseIntegrityView.php:232Replysidequestion: what is "disableTopMenu" in the first place good for? target for removal? -
Wouter Wolters commented on patch set 1 11/08/14, 15:24
DatabaseIntegrityView.php:232Reply+1 -
Wouter Wolters uploaded patch set 2 11/08/14, 16:12
-
Christian Kuhn commented on patch set 2 CR -1 11/08/14, 16:29
-1, working on it. -
Christian Kuhn uploaded patch set 3 11/08/14, 17:08
-
Christian Kuhn voted on patch set 3 CR +1 V +1 11/08/14, 17:08
-
Benni Mack voted on patch set 3 CR +2 V +2 11/08/14, 18:03
-
Benni Mack merged patch set 3 11/08/14, 18:03