Review main Merged

33902[TASK] Add hhvm to travis

Christian Kuhn CR +2 V +2 Easy +8 −3 updated 11/08/14, 14:34

Commit message

Running the test suite with hhvm shows some code smells and
actual issues the core with this interpreter. While unit tests
are in a fairly good shape already, functionals are still
totally broken.

Having hhvm in our standard test suite in travis as
"allowed failure" is a first step to raise awareness towards
this topic.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Wouter Wolters +1
  • Verified V +2
    • Christian Kuhn +2
    • Wouter Wolters +1

Issues 1

Files 1

Review log 5

  1. Christian Kuhn uploaded patch set 1 11/08/14, 12:10

  2. Christian Kuhn commented on patch set 1 11/08/14, 12:12

  3. Christian Kuhn commented on patch set 1 CR +2 V +2 11/08/14, 12:12

    Will merge soonish if no one objects, but please still feel free to +1 :)
  4. Wouter Wolters voted on patch set 1 V +1 CR +1 11/08/14, 14:01

  5. Christian Kuhn merged patch set 1 11/08/14, 14:34