Review main Merged Breaking

33983[!!!][TASK] Remove link.action vh from ext:documentation

Andreas Kienast CR +2 V +2 Normal +28 −82 updated 11/12/14, 07:26

Commit message

Remove the doc:link.action view helper in favor of f:be.buttons.icon.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Frank Nägler +1
  • Verified V +2
    • Christian Kuhn +2
    • Frank Nägler +1

Issues 1

Files 3

Review log 7

  1. Andreas Kienast uploaded patch set 1 11/11/14, 14:09

  2. Frank Nägler commented on patch set 1 CR -1 11/11/14, 14:36

    not sure, but should this viewHelper deprecated first before remove it? -1 until an other AC has reviewed.
  3. Frank Nägler commented on patch set 1 CR +1 11/11/14, 14:53

    after a short discussion with Jigal, it is ok to remove it.
  4. Frank Nägler voted on patch set 1 V +1 11/11/14, 23:00

  5. Christian Kuhn voted on patch set 1 CR +2 V +2 11/12/14, 07:25

  6. Christian Kuhn commented on patch set 1 11/12/14, 07:26

    Good job. Thx!
  7. Christian Kuhn merged patch set 1 11/12/14, 07:26