Review main Merged

33987[TASK] Cleanup CSH calls

Benni Mack CR +2 V +2 Normal +108 −87 updated 11/13/14, 14:07

Commit message

Due to a BackendUtility cleanup
there were some methods related to help
texts that were broken and unstructured.

Additionally, some methods are deprecated
for removal as they haven't been used since
TYPO3 CMS 4.5.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Christian Bülter +1
    • Frank Nägler +1
  • Verified V +2
    • Wouter Wolters +2
    • Christian Bülter +1
    • Frank Nägler +1

Issues 1

Files 34

Show 14 more files

Review log 11

  1. Benni Mack uploaded patch set 1 11/11/14, 15:50

  2. Wouter Wolters commented on patch set 1 11/11/14, 15:53

    PermissionModuleController.php:249

    Wrong check here lead to not shown CSH $this->docHeaderButtons and $docHeaderButtons

    PermissionModuleController.php:285

    This CSH is not shown at all
  3. Frank Nägler commented on patch set 1 V +1 CR +1 11/11/14, 22:46

    looks good to me
  4. Wouter Wolters uploaded patch set 2 11/13/14, 08:19

  5. Wouter Wolters commented on patch set 2 V +1 CR +1 11/13/14, 08:20

    Removed CSH from ext:perm and added a rst file for the deprecated function.
  6. Benni Mack uploaded patch set 3 11/13/14, 09:56

  7. Wouter Wolters voted on patch set 3 V +1 CR +1 11/13/14, 10:44

  8. Christian Bülter voted on patch set 3 CR +1 V +1 11/13/14, 13:30

  9. Frank Nägler voted on patch set 3 V +1 CR +1 11/13/14, 13:33

  10. Wouter Wolters voted on patch set 3 V +2 CR +2 11/13/14, 14:07

  11. Wouter Wolters merged patch set 3 11/13/14, 14:07