Review main Merged

33992[FEATURE] Remove conf.php for ext:filelist

Wouter Wolters CR +2 V +2 Normal +39 −19 updated 12/07/14, 19:45

Commit message

In order to be able to remove the conf.php a few fixes are needed.
The module dispatcher checks for a conf.php file and results in a error.
The language labels for the module menu for example are missing currently.
This patch adds a possibility to register the labels also in addModule
function.

Review

  • Code review CR +2
    • Helmut Hummel +2
    • Steffen Müller +1
  • Verified V +2
    • Helmut Hummel +2
    • Steffen Müller +1

Issues 1

Files 5

Review log 28

Show 3 earlier messages
  1. Wouter Wolters uploaded patch set 1 11/11/14, 21:55

  2. Steffen Müller commented on patch set 1 11/12/14, 09:02

    Thanks for that Wouter.

    FileListController.php:32

    What's the rule for removing public properties without deprecation?

    FileListController.php:119

    This line checks if the userhas access to the module. Why do you remove it?

    FileListController.php:201

    Use a class property or a constant instead of hardcoded strings. Also in the lines below.

    ext_tables.php:12

    should be 'user,group' instead of admin

    ext_tables.php:14

    in conf.php the values for workspaces were: 'online,custom'. Why did you remove them?

    ext_tables.php:17

    Maybe we can use EXT:filelist/Resources/Public/Icons/module-filelist.gif
  3. Wouter Wolters commented on patch set 1 11/12/14, 09:33

    FileListController.php:32 Reply

    We should somehow deprecate it or make it a breaking change, needs a discussion with more people

    FileListController.php:119 Reply

    This check is done in the ModuleLoader already as far as I could see

    FileListController.php:201 Reply

    Good idea for a class property

    ext_tables.php:12 Reply

    This was for testing the modAccess check:) Should be reverted to the original value

    ext_tables.php:14 Reply

    Wrong c&p I think, was late already

    ext_tables.php:17 Reply

    Will check that out later today
  1. Steffen Müller uploaded patch set 2 11/12/14, 11:46

  2. Steffen Müller commented on patch set 2 11/12/14, 11:49

    Fixed the mentioned issues. "EXT:" is not supported for labels/tabs_images/tabs,but could be added to ModuleLoader
  3. Steffen Müller commented on patch set 2 11/12/14, 11:50

    Just ask on the typo3-cms slack channel about deprecation of public class properties... We have to deprecate, even if it doesn't make sense to me.
  4. Wouter Wolters commented on patch set 2 11/12/14, 11:58

    ModuleLoader.php:258

    I left out the [default] here which was not needed. Is that a good idea

    ext_tables.php:13

    file_list
  5. Steffen Müller commented on patch set 2 11/12/14, 12:15

    ModuleLoader.php:258 Reply

    Yes

    ext_tables.php:13 Reply

    Done
  6. Steffen Müller uploaded patch set 3 11/12/14, 12:16

  7. Steffen Müller commented on patch set 2 11/12/14, 12:18

    I'd suggest to create a forge ticket and ask for reviews. Maybe also invite benni to a review, since he introduced the new addModule() parameter
  8. Wouter Wolters updated the commit message in patch set 4 11/12/14, 12:31

  9. Steffen Müller voted on patch set 4 CR +1 V +1 11/12/14, 13:53

  10. Helmut Hummel commented on patch set 4 CR +1 11/12/14, 15:27

    very nice Wouter! thanks a lot!
  11. Christian Kuhn commented on patch set 4 11/12/14, 16:43

    FileListController.php:119

    Is there a special reason to have this private? We usually don't do that.
  12. Christian Kuhn uploaded patch set 5 11/12/14, 16:50

  13. Helmut Hummel commented on patch set 4 11/12/14, 16:57

    FileListController.php:119 Reply

    good point! have overlooked this.
  14. Helmut Hummel voted on patch set 5 CR +1 11/12/14, 16:58

  15. Steffen Müller commented on patch set 5 11/12/14, 17:45

    FileListController.php:119

    I just didn't see a reason for protected. Changing the value will break the module, because it is cross-defined in addModule('file', 'list', ...) Maybe we make it a class constant instead. I am aware that our common practice is to use protected, but it wouldn't make sense here.
  16. Steffen Müller voted on patch set 5 CR +1 V +1 11/12/14, 20:02

  17. Wouter Wolters uploaded patch set 6 12/03/14, 16:37

  18. Wouter Wolters commented on patch set 6 12/03/14, 16:38

    Rebased because of changed module icons.
  19. Wouter Wolters uploaded patch set 7 12/03/14, 16:38

  20. Helmut Hummel voted on patch set 7 CR +2 V +2 12/04/14, 21:54

  21. Steffen Müller voted on patch set 7 CR +1 V +1 12/04/14, 22:01

  22. Helmut Hummel commented on patch set 7 CR -2 12/04/14, 22:02

    just one question
  23. Helmut Hummel voted on patch set 7 CR +2 12/04/14, 22:05

  24. Helmut Hummel merged patch set 7 12/04/14, 22:05

  25. Helmut Hummel commented on patch set 8 12/07/14, 19:45

    FileListController.php:119

    I've overseen this removal! The access check is mandantory. without it *every* backend user can access the module. Sorry for that!