33992[FEATURE] Remove conf.php for ext:filelist
Commit message
Review
-
Code review CR +2
- Helmut Hummel +2
- Steffen Müller +1
-
Verified V +2
- Helmut Hummel +2
- Steffen Müller +1
Issues 1
Files 5
Review log 28
Show 3 earlier messages
-
Wouter Wolters uploaded patch set 1 11/11/14, 21:55
-
Steffen Müller commented on patch set 1 11/12/14, 09:02
Thanks for that Wouter.FileListController.php:32What's the rule for removing public properties without deprecation?FileListController.php:119This line checks if the userhas access to the module. Why do you remove it?FileListController.php:201Use a class property or a constant instead of hardcoded strings. Also in the lines below.ext_tables.php:12should be 'user,group' instead of adminext_tables.php:14in conf.php the values for workspaces were: 'online,custom'. Why did you remove them?ext_tables.php:17Maybe we can use EXT:filelist/Resources/Public/Icons/module-filelist.gif -
Wouter Wolters commented on patch set 1 11/12/14, 09:33
FileListController.php:32ReplyWe should somehow deprecate it or make it a breaking change, needs a discussion with more peopleFileListController.php:119ReplyThis check is done in the ModuleLoader already as far as I could seeFileListController.php:201ReplyGood idea for a class propertyext_tables.php:12ReplyThis was for testing the modAccess check:) Should be reverted to the original valueext_tables.php:14ReplyWrong c&p I think, was late alreadyext_tables.php:17ReplyWill check that out later today
-
Steffen Müller uploaded patch set 2 11/12/14, 11:46
-
Steffen Müller commented on patch set 2 11/12/14, 11:49
Fixed the mentioned issues. "EXT:" is not supported for labels/tabs_images/tabs,but could be added to ModuleLoader -
Steffen Müller commented on patch set 2 11/12/14, 11:50
Just ask on the typo3-cms slack channel about deprecation of public class properties... We have to deprecate, even if it doesn't make sense to me. -
Wouter Wolters commented on patch set 2 11/12/14, 11:58
ModuleLoader.php:258I left out the [default] here which was not needed. Is that a good ideaext_tables.php:13file_list -
Steffen Müller commented on patch set 2 11/12/14, 12:15
ModuleLoader.php:258ReplyYesext_tables.php:13ReplyDone -
Steffen Müller uploaded patch set 3 11/12/14, 12:16
-
Steffen Müller commented on patch set 2 11/12/14, 12:18
I'd suggest to create a forge ticket and ask for reviews. Maybe also invite benni to a review, since he introduced the new addModule() parameter -
Wouter Wolters updated the commit message in patch set 4 11/12/14, 12:31
-
Steffen Müller voted on patch set 4 CR +1 V +1 11/12/14, 13:53
-
Helmut Hummel commented on patch set 4 CR +1 11/12/14, 15:27
very nice Wouter! thanks a lot! -
Christian Kuhn commented on patch set 4 11/12/14, 16:43
FileListController.php:119Is there a special reason to have this private? We usually don't do that. -
Christian Kuhn uploaded patch set 5 11/12/14, 16:50
-
Helmut Hummel commented on patch set 4 11/12/14, 16:57
FileListController.php:119Replygood point! have overlooked this. -
Helmut Hummel voted on patch set 5 CR +1 11/12/14, 16:58
-
Steffen Müller commented on patch set 5 11/12/14, 17:45
FileListController.php:119I just didn't see a reason for protected. Changing the value will break the module, because it is cross-defined in addModule('file', 'list', ...) Maybe we make it a class constant instead. I am aware that our common practice is to use protected, but it wouldn't make sense here. -
Steffen Müller voted on patch set 5 CR +1 V +1 11/12/14, 20:02
-
Wouter Wolters uploaded patch set 6 12/03/14, 16:37
-
Wouter Wolters commented on patch set 6 12/03/14, 16:38
Rebased because of changed module icons. -
Wouter Wolters uploaded patch set 7 12/03/14, 16:38
-
Helmut Hummel voted on patch set 7 CR +2 V +2 12/04/14, 21:54
-
Steffen Müller voted on patch set 7 CR +1 V +1 12/04/14, 22:01
-
Helmut Hummel commented on patch set 7 CR -2 12/04/14, 22:02
just one question -
Helmut Hummel voted on patch set 7 CR +2 12/04/14, 22:05
-
Helmut Hummel merged patch set 7 12/04/14, 22:05
-
Helmut Hummel commented on patch set 8 12/07/14, 19:45
FileListController.php:119I've overseen this removal! The access check is mandantory. without it *every* backend user can access the module. Sorry for that!