34006[TASK] Cleanup for LocalDriver
Commit message
Review
-
Code review CR +2
- Stefan Neufeind +2
- Markus Klein +1
-
Verified V +2
- Stefan Neufeind +2
- Markus Klein +1
Issues 1
Files 1
Review log 6
-
Frederic Gaus uploaded patch set 1 11/12/14, 12:25
-
Stefan Neufeind uploaded patch set 2 11/23/14, 23:00
-
Stefan Neufeind commented on patch set 2 CR +1 11/23/14, 23:02
Not a big change, right. But you missed to also move the dirPath-calculation (which is mentioned in the forge-issue you mentioned in the Resolves-line). Also your commit-msg should describe what the issue is or what you are modifying. Leave decisions what a no-brainer is up to the reviewer :-) -
Markus Klein voted on patch set 2 CR +1 V +1 11/24/14, 00:01
-
Stefan Neufeind voted on patch set 2 CR +2 V +2 11/24/14, 08:26
-
Stefan Neufeind merged patch set 2 11/24/14, 08:26