Review main Merged

34011[FOLLOWUP][BUGFIX] Use bootstrap JS as include instead of AMD

Benni Mack CR +2 V +2 Easy +7 −6 updated 11/12/14, 14:48

Commit message

Bootstrap JS is included as AMD module,
thus breaking things like Extension Manager
which was coded in an uncool way, namely
not using API methods due to crappy Fluid
ViewHelpers for the backend.

For the time being and to keep everybody
happy, bootstrapJS is included as simple JS
file, but wrapped within TYPO3.jQuery to
use the previously loaded functionality.

Review

  • Code review CR +2
    • Benni Mack +2
    • Frank Nägler +1
    • Andreas Kienast +1
  • Verified V +2
    • Benni Mack +2
    • Frank Nägler +1
    • Andreas Kienast +1

Issues 1

Files 2

Review log 5

  1. Benni Mack uploaded patch set 1 11/12/14, 13:23

  2. Frank Nägler voted on patch set 1 V +1 CR +1 11/12/14, 14:44

  3. Andreas Kienast voted on patch set 1 CR +1 V +1 11/12/14, 14:47

  4. Benni Mack voted on patch set 1 CR +2 V +2 11/12/14, 14:48

  5. Benni Mack merged patch set 1 11/12/14, 14:48