Review main Merged Breaking

34015[!!!][TASK] Gifbuilder: Always use full filename of original file as prefix

Georg Ringer CR +2 V +2 Normal +35 −30 updated 01/24/15, 09:16

Commit message

As of now, images created with GIFBUILDER were created by a
hash in typo3temp/GB/. With the TypoScript option
config.meaningfulTempFilePrefix it was possible to prepend the
first X characters of the original filename in the filename.
This was due to some FS limitations on Windows.

With FAL the option was not used anymore, but Gifbuilder
still used this option.

In order to streamline the generation of temporary
files, images created by the Gifbuilder now contain
the full filename of the original file as well.

The TypoScript option "config.meaningfulTempFilePrefix"
has no effect anymore now.

Review

  • Code review CR +2
    • Benni Mack +2
    • Eric Chavaillaz +1
  • Verified V +2
    • Benni Mack +2
    • Eric Chavaillaz +1

Issues 1

Files 4

Review log 33

Show 8 earlier messages
  1. Georg Ringer uploaded patch set 1 11/12/14, 14:42

  2. Andreas Kienast commented on patch set 1 11/12/14, 14:46

    GifBuilder.php:691

    meaningfulPrefixLength is set twice
  3. Georg Ringer uploaded patch set 2 11/12/14, 14:57

  4. Andreas Kienast voted on patch set 2 CR +1 11/12/14, 14:58

  5. Helmut Hummel commented on patch set 2 CR -1 11/12/14, 15:00

    A few remarks on that one: meaningfulTempFilePrefix is not used any more at all since introduction of FAL in 6.0 for processed images. currently the original file name is prepended, regardless of this setting. It is still used for gifbuilder and graphical menus (where the latter should be deprecated anyways) besides that: "strong default" does not mean not configurable at all. So the question remains if there is a use case for not having too long file names. If so, we should not remove the setting but set it to a reasonable default, but keep it overridable by configuration
  6. Benni Mack uploaded patch set 3 11/12/14, 15:04

  7. Georg Ringer voted on patch set 3 CR +1 V +1 11/12/14, 15:11

  8. Mathias Schreiber commented on patch set 3 CR +1 V +1 11/12/14, 16:46

    does what it's intended to do :)
  1. Helmut Hummel voted on patch set 3 CR -2 11/12/14, 16:47

  2. Helmut Hummel commented on patch set 3 11/12/14, 16:51

    This does not make sense. As pointed out, "strong defaults" means default configuration is set to something that makes sense by default, not that configurability is removed. please elaborate why this is not needed any more.
  3. Helmut Hummel commented on patch set 3 11/12/14, 16:56

    GifBuilder.php:686

    if we don't need the setting any more, why limit it to a hard coded value and not align with FAL image processing where there is no limit implemented currently. Or is there a followup planned which aligns FAL image processing also to a limit of 100 chars of the original file name?
  4. Helmut Hummel commented on patch set 3 CR -1 11/12/14, 17:24

    Please consider my remarks, thanks
  5. Benni Mack uploaded patch set 4 11/12/14, 17:40

  6. Wouter Wolters updated the commit message in patch set 5 11/12/14, 17:44

  7. Wouter Wolters voted on patch set 5 CR +1 11/12/14, 17:49

  8. Georg Ringer voted on patch set 5 CR +1 V +1 11/15/14, 21:50

  9. Georg Ringer uploaded patch set 6 11/15/14, 21:54

  10. Eric Chavaillaz voted on patch set 6 V +1 CR +1 12/12/14, 09:42

  11. Benni Mack voted on patch set 6 CR +1 12/12/14, 19:16

  12. Christian Kuhn commented on patch set 6 CR -1 12/12/14, 21:19

    I have the same questions as Helmut on the arbitrary limit. -1 until those are sorted out.
  13. Benni Mack commented on patch set 6 12/13/14, 10:00

    christian, please elaborate. I came up with a new patch removing the option completely (to be aligned with FAL file creation).
  14. Mathias Schreiber wrote 12/17/14, 14:33

    Topic set to EXT: t3editor
  15. Benni Mack commented on patch set 6 12/23/14, 23:49

    ping lolli :)
  16. Benni Mack wrote 01/07/15, 17:16

    Topic changed from EXT: t3editor to GIFBUILDER
  17. Christian Kuhn voted on patch set 6 CR 0 01/22/15, 19:12

  18. Benni Mack voted on patch set 6 CR +2 01/23/15, 16:40

  19. Benni Mack voted on patch set 6 V +2 01/23/15, 16:47

  20. Benni Mack merged patch set 6 01/23/15, 16:47

  21. Frans Saris commented on patch set 7 01/23/15, 20:30

    GifBuilder.php:680

    Where is the max 100 checked?
  22. Benni Mack commented on patch set 7 01/23/15, 21:59

    GifBuilder.php:680 Reply

    good point, it isn't anymore (was in Patchset 1). The comment can safely be removed.
  23. Philipp Gampe commented on patch set 7 01/23/15, 23:16

    post -1, this is creating problems for windows users which are stuck with 260 chars total path lengh @see comments from Helmut which have been ignored in the review process
  24. Stephan Großberndt commented on patch set 7 01/24/15, 09:01

    I am currently trying to make the windows support better again. Did you test this on windows?
  25. Stephan Großberndt commented on patch set 7 01/24/15, 09:16

    it seems even in Windows 10 the limit is still there. please revert or fix this in another way.